From: Eric Sandeen <sandeen@redhat.com>
To: Avantika Mathur <mathur@linux.vnet.ibm.com>
Cc: Andreas Dilger <adilger@clusterfs.com>, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] uninitialized groups ported - kernel
Date: Tue, 05 Jun 2007 13:48:15 -0500 [thread overview]
Message-ID: <4665AFEF.3060602@redhat.com> (raw)
In-Reply-To: <1181065733.5219.8.camel@mathur-dsktp>
Avantika Mathur wrote:
> Hi Andreas,
>
> I have ported your uninitialized block group kernel patch to mainline
> 2.6.22-rc3, included below.
> I will also be posting the ported e2fsprogs patches. I had trouble
> testing the patches because of inconsistency in the block_group
> structure in e2fsprogs - which is only using ext2_block_group, and not
> ext4_block_group.
>
> Thanks
> Avantika
>
> ---
...
> +#if !defined(CONFIG_CRC16) && !defined(CONFIG_CRC16_MODULE)
> +/** CRC table for the CRC-16. The poly is 0x8005 (x16 + x15 + x2 + 1) */
> +__u16 const crc16_table[256] = {
> + 0x0000, 0xC0C1, 0xC181, 0x0140, 0xC301, 0x03C0, 0x0280, 0xC241,
> + 0xC601, 0x06C0, 0x0780, 0xC741, 0x0500, 0xC5C1, 0xC481, 0x0440,
Apologies if this has already been discussed & I missed it, but why
replicate all this? why not just require CONFIG_CRC16?
-Eric
next prev parent reply other threads:[~2007-06-05 18:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-05 17:48 [PATCH] uninitialized groups ported - kernel Avantika Mathur
2007-06-05 18:48 ` Eric Sandeen [this message]
2007-06-05 21:20 ` Andreas Dilger
2007-06-19 4:04 ` Avantika Mathur
2007-06-19 7:50 ` Andreas Dilger
2007-06-20 11:56 ` Girish Shilamkar
2007-06-21 17:37 ` Andreas Dilger
2007-06-21 23:54 ` Avantika Mathur
2007-06-22 16:04 ` Andreas Dilger
2007-06-22 16:20 ` Dave Kleikamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4665AFEF.3060602@redhat.com \
--to=sandeen@redhat.com \
--cc=adilger@clusterfs.com \
--cc=linux-ext4@vger.kernel.org \
--cc=mathur@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.