From: Chris Snook <csnook@redhat.com>
To: Paul Mackerras <paulus@samba.org>
Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH TRIVIAL] icom whitespace cleanups
Date: Tue, 05 Jun 2007 19:00:17 -0400 [thread overview]
Message-ID: <4665EB01.5040508@redhat.com> (raw)
In-Reply-To: <18021.55632.359206.105260@cargo.ozlabs.ibm.com>
Paul Mackerras wrote:
> Chris Snook writes:
>
>> Clean up whitespace and comments in drivers/serial/icom.c
>
> These changes seem totally unnecessary, as the existing indentation is
> according to a commonly-accepted style and is quite reasonable:
There are actually a few different indentation styles used inconsistently
throughout, which I personally find annoying, and there's lots of whitespace
damage. If I've really overstepped the bounds, I'll resubmit a somewhat smaller
patch, but I'm inclined to make it look pretty while I've got the hood up.
> Also you don't seem to have cc'd the driver author.
Can't find any contact info. Care to enlighten me?
-- Chris
next prev parent reply other threads:[~2007-06-05 23:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-05 21:21 [PATCH TRIVIAL] icom whitespace cleanups Chris Snook
2007-06-05 21:44 ` Paul Mackerras
2007-06-05 23:00 ` Chris Snook [this message]
2007-06-06 14:16 ` V. Ananda Krishnan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4665EB01.5040508@redhat.com \
--to=csnook@redhat.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.