From: Richard Knutsson <ricknu-0@student.ltu.se>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] DMA_{32,64}BIT_MASK
Date: Wed, 06 Jun 2007 03:23:13 +0000 [thread overview]
Message-ID: <466628A1.6030707@student.ltu.se> (raw)
In-Reply-To: <ab8e556c0706051859i6c3df99chdf635b4d962b1871@mail.gmail.com>
Kevin Jackson wrote:
> Hi,
>
> Based on this TODO:
> - pci_set_dma_mask() and friends should use DMA_{32,64}BIT_MASK
> instead of...
>
> I started playing with grep to see if I could find any code which
> wasn't using this DMA_32|64BIT_MASK.
>
> In drivers/scsi/3w-xxxx.c, instead of using DMA_32BIT_MASK the
> pci_set_dma_mask uses TW_DMA_MASK which is declared in
> drivers/scsi/3-xxxx.h :
>
> #define TW_DMA_MASK DMA_32BIT_MASK
>
> This looks to my untrained eye like an API was changed and to get
> compatibility, the TW_DMA_MASK was simply defined to be the same as
> DMA_32BIT_MASK.
>
> Again this is my second day (about 4 hours in) at looking at kernel
> code, but my naive assumption is that nothing would be lost by
> removing the TW_DMA_MASK definition completely from both the .c and .h
> files and using the DMA_32BIT_MASK directly.
>
> Can anyone tell me that I'm either correct or talking total crap? :)
> If I'm right about this the next step would of course be to supply a
> (very minor) patch with the changes... scary stuff ;)
As it does not add any information by the name (and only used once), I
would say you are right on the spot. :)
Please send in your patch. (BTW, check out
Documentation/SubmittingPatches if you have not done it yet).
Richard Knutsson
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors
prev parent reply other threads:[~2007-06-06 3:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-06 1:59 [KJ] DMA_{32,64}BIT_MASK Kevin Jackson
2007-06-06 3:23 ` Richard Knutsson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=466628A1.6030707@student.ltu.se \
--to=ricknu-0@student.ltu.se \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.