From: Tejun Heo <htejun@gmail.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: Mikael Pettersson <mikpe@it.uu.se>,
akpm@linux-foundation.org, david@dgreaves.com,
jean.luc.coulon@gmail.com, jgarzik@pobox.com,
michal.k.k.piotrowski@gmail.com, torvalds@linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: Linux 2.6.22-rc4 - sata_promise regression since -rc3
Date: Wed, 06 Jun 2007 15:56:53 +0900 [thread overview]
Message-ID: <46665AB5.6040508@gmail.com> (raw)
In-Reply-To: <20070605215256.GT31565@havoc.gtf.org>
Hello,
Jeff Garzik wrote:
> On Tue, Jun 05, 2007 at 11:31:46PM +0200, Mikael Pettersson wrote:
>> I can easily reproduce the problem in 2.6.22-rc4. There are no
>> sata_promise changes between rc3 and rc4, but Tejun's libata
>> polling SETXFER change was included in rc4. Reverting it makes
>> sata_promise work again for me.
>
> Ugh.
Ugh...
>> I suspect that sata_promise.c:pdc_interrupt() should detect
>> a qc w/ ATA_TFLAG_POLLING, treat the interrupt as spurious,
>> and just call ata_chk_status(qc), similar to how sata_inic162x.c,
>> sata_nv.c, sata_sil.c, and sata_vsc.c do things.
>
> Yes, highly likely.
I'm not sure whether that will work. I'll give a shot at it here.
> SFF-like controllers (and in this case, Promise is included in that
> list) with their own interrupt handlers need their own polling handling
> code.
One thing I don't understand is why IDENTIFY works. IDENTIFY uses
polling too. Hmm...
--
tejun
next prev parent reply other threads:[~2007-06-06 6:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-05 21:31 Linux 2.6.22-rc4 - sata_promise regression since -rc3 Mikael Pettersson
2007-06-05 21:52 ` Jeff Garzik
2007-06-05 23:37 ` walt
2007-06-06 6:56 ` Tejun Heo [this message]
2007-06-06 10:21 ` [REPOST PATCH] sata_promise: use TF interface for polling NODATA commands Tejun Heo
2007-06-06 15:42 ` walt
2007-06-06 16:05 ` Jeff Garzik
2007-06-06 16:34 ` Alan Cox
2007-06-07 17:20 ` Chuck Ebbert
2007-06-07 17:25 ` Jeff Garzik
2007-06-07 17:30 ` Jeff Garzik
2007-06-07 15:17 ` Jeff Garzik
2007-06-07 15:45 ` Andrew Morton
-- strict thread matches above, loose matches on Subject: below --
2007-06-06 10:36 Linux 2.6.22-rc4 - sata_promise regression since -rc3 Mikael Pettersson
2007-06-05 3:50 Linux 2.6.22-rc4 Linus Torvalds
2007-06-05 16:14 ` Linux 2.6.22-rc4 - sata_promise regression since -rc3 David Greaves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46665AB5.6040508@gmail.com \
--to=htejun@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=david@dgreaves.com \
--cc=jean.luc.coulon@gmail.com \
--cc=jeff@garzik.org \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.k.k.piotrowski@gmail.com \
--cc=mikpe@it.uu.se \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.