From: Kev Jackson <foamdino@gmail.com>
To: linuxraid@amcc.com, linux-scsi@vger.kernel.org
Subject: [patch] Use DMA_32BIT_MASK where appropriate in drivers/scsi/3w-xxxx.c|h
Date: Wed, 06 Jun 2007 16:53:30 +0700 [thread overview]
Message-ID: <4666841A.8010207@gmail.com> (raw)
From: Kev Jackson <foamdino@gmail.com>
-Remove TW_DMA_MASK and use DMA_32BIT_MASK as listed in kernel janitors TODO list
Signed-off-by: Kev Jackson <foamdino@gmail.com>
---
drivers/scsi/3w-xxxx.c | 2 +-
drivers/scsi/3w-xxxx.h | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)
-patch applies fine on current kernel tree & new kernel compiles
-previously submitted to kernel-janitors@lists.osdl.org
diff --git a/drivers/scsi/3w-xxxx.c b/drivers/scsi/3w-xxxx.c
index 656bdb1..15ca2a0 100644
--- a/drivers/scsi/3w-xxxx.c
+++ b/drivers/scsi/3w-xxxx.c
@@ -2338,7 +2338,7 @@ static int __devinit tw_probe(struct pci_dev *pdev, const struct pci_device_id *
pci_set_master(pdev);
- retval = pci_set_dma_mask(pdev, TW_DMA_MASK);
+ retval = pci_set_dma_mask(pdev, DMA_32BIT_MASK);
if (retval) {
printk(KERN_WARNING "3w-xxxx: Failed to set dma mask.");
goto out_disable_device;
diff --git a/drivers/scsi/3w-xxxx.h b/drivers/scsi/3w-xxxx.h
index 0742e68..4efd6c2 100644
--- a/drivers/scsi/3w-xxxx.h
+++ b/drivers/scsi/3w-xxxx.h
@@ -234,7 +234,6 @@ static unsigned char tw_sense_table[][4] =
#define TW_IOCTL_TIMEOUT 25 /* 25 seconds */
#define TW_IOCTL_CHRDEV_TIMEOUT 60 /* 60 seconds */
#define TW_IOCTL_CHRDEV_FREE -1
-#define TW_DMA_MASK DMA_32BIT_MASK
#define TW_MAX_CDB_LEN 16
/* Bitmask macros to eliminate bitfields */
reply other threads:[~2007-06-06 9:53 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4666841A.8010207@gmail.com \
--to=foamdino@gmail.com \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxraid@amcc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.