From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: xt_gateway 20070605 (kernel) Date: Wed, 06 Jun 2007 13:31:14 +0200 Message-ID: <46669B02.2010905@trash.net> References: <46657E13.50106@trash.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Cc: Netfilter Developer Mailing List , Amin Azez To: Jan Engelhardt Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: netfilter-devel-bounces@lists.netfilter.org Errors-To: netfilter-devel-bounces@lists.netfilter.org List-Id: netfilter-devel.vger.kernel.org Jan Engelhardt wrote: > On Jun 5 2007 17:15, Patrick McHardy wrote: > >>Most of the checks here are unnecessary anyway (we always >>have a skb with skb->dst != NULL, neigh->tbl is always != NULL >>and the neighbour table family is always AF_INET since the >>match is only registered for AF_INET. > > > Thanks for letting us now. Now, prime question: Is skb always != NULL? > (Otherwise it would not really make sense calling the match if > there was nothing to match.) Yes.