From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Hw0nx-0000Px-2I for mharc-grub-devel@gnu.org; Wed, 06 Jun 2007 15:04:25 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Hw0nv-0000Pp-As for grub-devel@gnu.org; Wed, 06 Jun 2007 15:04:23 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Hw0nt-0000PQ-K7 for grub-devel@gnu.org; Wed, 06 Jun 2007 15:04:22 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Hw0nt-0000PN-Dq for grub-devel@gnu.org; Wed, 06 Jun 2007 15:04:21 -0400 Received: from 245.red-80-24-127.staticip.rima-tde.net ([80.24.127.245] helo=manazas.ensanjose.net) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Hw0ns-0003cE-N4 for grub-devel@gnu.org; Wed, 06 Jun 2007 15:04:21 -0400 Received: from localhost (manazas.ensanjose.net [127.0.0.1]) by manazas.ensanjose.net (Postfix) with ESMTP id 135BAD444E for ; Wed, 6 Jun 2007 21:04:16 +0200 (CEST) Received: from manazas.ensanjose.net ([127.0.0.1]) by localhost (manazas.ensanjose.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 21216-05 for ; Wed, 6 Jun 2007 21:04:15 +0200 (CEST) Received: from [192.168.1.10] (246.Red-83-38-190.dynamicIP.rima-tde.net [83.38.190.246]) by manazas.ensanjose.net (Postfix) with ESMTP id B5929D444D for ; Wed, 6 Jun 2007 21:04:15 +0200 (CEST) Message-ID: <4666F71D.5010403@raulete.net> Date: Wed, 06 Jun 2007 20:04:13 +0200 From: adrian15 User-Agent: Mozilla Thunderbird 1.0.7 (Windows/20050923) X-Accept-Language: en-us, en MIME-Version: 1.0 To: grub-devel@gnu.org References: <200706051834.l55IY56F003249@correoredir01.dinaserver.com> In-Reply-To: <200706051834.l55IY56F003249@correoredir01.dinaserver.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-detected-kernel: Linux 2.4-2.6 Subject: Re: gcs doubt #1 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Jun 2007 19:04:23 -0000 >>> If you can provide a patch for sourcecode to improve or add comments >>> in a sane way, I am willing to commit those patches. Just please >>> don't make the mistake to add useless comments. >> An useful comment is one that: >> -Describes a function algorithm >> -Describes what a function does (as a black box) >> -Boot of them ? > > Yes, but I oppose to adding obvious comments. But patches will be > reviewed, so you will learn fast enough what we want :-). You had to choose one of the three options :). Well... it doesn't matter. I've understood that I have to send patches and learn by trial-error. adrian15