From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Lively <dlively@virtualiron.com>
Subject: Re: [PATCH] [HVM] Fix 64 bit PV-on-HVM driver builds
Date: Wed, 06 Jun 2007 15:20:51 -0400
Message-ID: <46670913.2000709@virtualiron.com>
References: <C28CC231.1032E%keir@xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <C28CC231.1032E%keir@xensource.com>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Keir Fraser <keir@xensource.com>
Cc: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

Keir Fraser wrote:

>In the patch it's pgtable-nopmd.h. But pgtable-nopud.h makes more sense
>(x86/64 Linux has always had proper pmds). So is the patch incorrect?
>  
>
Oops.  You're absolutely right.  Both define pud_t, but nopud.h is 
definitely the correct one.  Thanks for catching this ....

>Also, this could be placed inside asm-x86_64/mach-xen/asm/hypervisor.h,
>couldn't it?
>
> -- Keir
>
>  
>
I tried that.  But since the x86_64 hypervisor.h includes the i386 
hypervisor.h, I have to put the conditional include of pgtable-nopud.h 
either before or after the include of i386 hypervisor.h, neither of 
which compiles on pre-2.6.11 kernels.

Dave