From: Albert Lee <albertcc@tw.ibm.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: Linux IDE <linux-ide@vger.kernel.org>, Doug Maxey <dwm@enoyolf.org>
Subject: [PATCH 4/6] libata: always enforce correct DEV bit
Date: Thu, 07 Jun 2007 15:52:07 +0800 [thread overview]
Message-ID: <4667B927.3080003@tw.ibm.com> (raw)
In-Reply-To: <4667B767.5060601@tw.ibm.com>
Patch 4/6:
Always enforce correct DEV bit since we know which drive the command
is targeted. SAT demands to ignore the DEV bit, too.
Signed-off-by: Albert Lee <albertcc@tw.ibm.com>
---
diff -Nrup 03_udma_supp/drivers/ata/libata-scsi.c 04_dev_bit/drivers/ata/libata-scsi.c
--- 03_udma_supp/drivers/ata/libata-scsi.c 2007-06-07 11:41:30.000000000 +0800
+++ 04_dev_bit/drivers/ata/libata-scsi.c 2007-06-07 14:44:27.000000000 +0800
@@ -2595,12 +2595,10 @@ static unsigned int ata_scsi_pass_thru(s
tf->device = cdb[8];
tf->command = cdb[9];
}
- /*
- * If slave is possible, enforce correct master/slave bit
- */
- if (qc->ap->flags & ATA_FLAG_SLAVE_POSS)
- tf->device = qc->dev->devno ?
- tf->device | ATA_DEV1 : tf->device & ~ATA_DEV1;
+
+ /* enforce correct master/slave bit */
+ tf->device = dev->devno ?
+ tf->device | ATA_DEV1 : tf->device & ~ATA_DEV1;
/* sanity check for pio multi commands */
if ((cdb[1] & 0xe0) && !is_multi_taskfile(tf))
next prev parent reply other threads:[~2007-06-07 7:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-07 7:44 [PATCH 0/6] libata: ATA passthru fixes Albert Lee
2007-06-07 7:47 ` [PATCH 1/6] libata: update protocol numbers Albert Lee
2007-06-10 2:46 ` Jeff Garzik
2007-06-10 3:12 ` Jeff Garzik
2007-06-10 22:31 ` Mark Lord
2007-06-15 14:45 ` Jeff Garzik
2007-06-07 7:49 ` [PATCH 2/6] libata: support PIO multi commands Albert Lee
2007-06-07 7:50 ` [PATCH 3/6] libata: map UDMA protocols Albert Lee
2007-06-07 7:52 ` Albert Lee [this message]
2007-06-07 7:59 ` [PATCH 5/6] libata: support ATAPI devices Albert Lee
2007-06-07 8:01 ` [PATCH 6/6] libata: update cached device paramters Albert Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4667B927.3080003@tw.ibm.com \
--to=albertcc@tw.ibm.com \
--cc=albertl@mail.com \
--cc=dwm@enoyolf.org \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.