From: Michael Krufky <mkrufky@linuxtv.org>
To: Mauro Carvalho Chehab <mchehab@infradead.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
v4l-dvb-maintainer@linuxtv.org, linux-dvb@linuxtv.org,
Linux Kernel Development <linux-kernel@vger.kernel.org>
Subject: Re: [v4l-dvb-maintainer] drivers/media/dvb/b2c2/flexcop-dma.c uses PCI DMA API
Date: Thu, 07 Jun 2007 10:03:44 -0400 [thread overview]
Message-ID: <46681040.2010003@linuxtv.org> (raw)
In-Reply-To: <1181220656.4187.64.camel@gaivota>
Mauro Carvalho Chehab wrote:
> Hi Geert,
>
> Em Qua, 2007-06-06 às 21:11 +0200, Geert Uytterhoeven escreveu:
>
>> Hi,
>>
>> drivers/media/dvb/b2c2/flexcop-dma.c uses the PCI DMA API, but DVB_B2C2_FLEXCOP
>> doesn't depend on PCI, causing the following problem on PCI-less systems:
>>
>> | linux/drivers/media/dvb/b2c2/flexcop-dma.c:20: warning: implicit declaration of function 'pci_alloc_consistent'
>> | linux/drivers/media/dvb/b2c2/flexcop-dma.c:20: warning: implicit declaration of function 'pci_alloc_consistent'
>>
>> Apparently this is the flexcop DMA core, which is used by both
>> DVB_B2C2_FLEXCOP_PCI and DVB_B2C2_FLEXCOP_USB.
>>
>> DVB_B2C2_FLEXCOP_PCI depends on PCI.
>> DVB_B2C2_FLEXCOP_USB depends on USB.
>>
>
> Thanks for pointing us about this issue. While the usage of the generic
> dma is the better way, a simple fix can be applied by simply moving
> flexcop-dma to b2c2-flexcop-pci (currently, only the last uses the DMA
> stuff). I've committed such patch. It is available at:
>
> http://linuxtv.org/hg/v4l-dvb/rev/c314ec17335a
>
Mauro,
It appears that your change has caused the following build warning:
WARNING: "b2c2_flexcop_debug"
[/home/mk/v4l-dvb-master/v4l/b2c2-flexcop-pci.ko] undefined!
Regards,
Mike
next prev parent reply other threads:[~2007-06-07 14:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-06 19:11 drivers/media/dvb/b2c2/flexcop-dma.c uses PCI DMA API Geert Uytterhoeven
2007-06-07 12:50 ` Mauro Carvalho Chehab
2007-06-07 14:03 ` Michael Krufky [this message]
2007-06-07 14:10 ` [v4l-dvb-maintainer] " Mauro Carvalho Chehab
2007-06-07 20:41 ` Trent Piepho
2007-06-08 12:30 ` Mauro Carvalho Chehab
2007-06-08 18:18 ` Trent Piepho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46681040.2010003@linuxtv.org \
--to=mkrufky@linuxtv.org \
--cc=geert@linux-m68k.org \
--cc=linux-dvb@linuxtv.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=v4l-dvb-maintainer@linuxtv.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.