From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from galahad.ideasonboard.com ([185.26.127.97]:32982 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751771AbdADL6X (ORCPT ); Wed, 4 Jan 2017 06:58:23 -0500 From: Laurent Pinchart To: Thierry Reding Cc: Laurent Pinchart , dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Stefan Agner Subject: Re: [PATCH v2.1 04/13] drm: Add data transmission order bus flag Date: Wed, 04 Jan 2017 13:58:26 +0200 Message-ID: <4668322.BBvS3ppBQr@avalon> In-Reply-To: <20170104070654.GB5729@ulmo.ba.sec> References: <7f668e382fa001811f961abfb398c9c9@agner.ch> <20170104003926.29683-1-laurent.pinchart+renesas@ideasonboard.com> <20170104070654.GB5729@ulmo.ba.sec> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Thierry, On Wednesday 04 Jan 2017 08:06:54 Thierry Reding wrote: > On Wed, Jan 04, 2017 at 02:39:26AM +0200, Laurent Pinchart wrote: > > The flags indicate whether data is transmitted lsb to msb or msb to lsb > > on the bus. > > > > The exact meaning is bus-type dependent. For instance, for LVDS buses > > the flags indicate whether the seven data bits transmitted in a clock > > pulse are sent in normal order (msb to lsb, slots 0 to 6) or reverse > > order (lsb to msb, slots 6 to 0). > > > > Signed-off-by: Laurent Pinchart > > > > --- > > Changes since v2: > > > > - Rename the flag to DRM_BUS_FLAG_DATA_LSB_TO_MSB and add a > > > > corresponding DRM_BUS_FLAG_DATA_MSB_TO_LSB flag. > > > > --- > > > > include/drm/drm_connector.h | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h > > index a9b95246e26e..712f255577ea 100644 > > --- a/include/drm/drm_connector.h > > +++ b/include/drm/drm_connector.h > > @@ -160,6 +160,10 @@ struct drm_display_info { > > > > #define DRM_BUS_FLAG_PIXDATA_POSEDGE (1<<2) > > /* drive data on neg. edge */ > > #define DRM_BUS_FLAG_PIXDATA_NEGEDGE (1<<3) > > > > +/* data is transmitted msb to lsb on the bus */ > > +#define DRM_BUS_FLAG_DATA_MSB_TO_LSB (1<<4) > > +/* data is transmitted lsb to msb on the bus */ > > +#define DRM_BUS_FLAG_DATA_LSB_TO_MSB (1<<5) > > Nit: "LSB" and "MSB" because they're abbreviations. If I end up applying > this I'll probably do that myself, and I leave it up to whoever else > might apply it whether or not they want to be pedantic, so: > > Reviewed-by: Thierry Reding Thank you. I'll fix that in my tree too. I went for lower case because bit is usually abbreviated b and byte B, but I don't think it really conveys that meaning anyway :-) -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v2.1 04/13] drm: Add data transmission order bus flag Date: Wed, 04 Jan 2017 13:58:26 +0200 Message-ID: <4668322.BBvS3ppBQr@avalon> References: <7f668e382fa001811f961abfb398c9c9@agner.ch> <20170104003926.29683-1-laurent.pinchart+renesas@ideasonboard.com> <20170104070654.GB5729@ulmo.ba.sec> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from galahad.ideasonboard.com (galahad.ideasonboard.com [185.26.127.97]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5CBF56E249 for ; Wed, 4 Jan 2017 11:58:22 +0000 (UTC) In-Reply-To: <20170104070654.GB5729@ulmo.ba.sec> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Thierry Reding Cc: linux-renesas-soc@vger.kernel.org, Laurent Pinchart , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGkgVGhpZXJyeSwKCk9uIFdlZG5lc2RheSAwNCBKYW4gMjAxNyAwODowNjo1NCBUaGllcnJ5IFJl ZGluZyB3cm90ZToKPiBPbiBXZWQsIEphbiAwNCwgMjAxNyBhdCAwMjozOToyNkFNICswMjAwLCBM YXVyZW50IFBpbmNoYXJ0IHdyb3RlOgo+ID4gVGhlIGZsYWdzIGluZGljYXRlIHdoZXRoZXIgZGF0 YSBpcyB0cmFuc21pdHRlZCBsc2IgdG8gbXNiIG9yIG1zYiB0byBsc2IKPiA+IG9uIHRoZSBidXMu Cj4gPiAKPiA+IFRoZSBleGFjdCBtZWFuaW5nIGlzIGJ1cy10eXBlIGRlcGVuZGVudC4gRm9yIGlu c3RhbmNlLCBmb3IgTFZEUyBidXNlcwo+ID4gdGhlIGZsYWdzIGluZGljYXRlIHdoZXRoZXIgdGhl IHNldmVuIGRhdGEgYml0cyB0cmFuc21pdHRlZCBpbiBhIGNsb2NrCj4gPiBwdWxzZSBhcmUgc2Vu dCBpbiBub3JtYWwgb3JkZXIgKG1zYiB0byBsc2IsIHNsb3RzIDAgdG8gNikgb3IgcmV2ZXJzZQo+ ID4gb3JkZXIgKGxzYiB0byBtc2IsIHNsb3RzIDYgdG8gMCkuCj4gPiAKPiA+IFNpZ25lZC1vZmYt Ynk6IExhdXJlbnQgUGluY2hhcnQKPiA+IDxsYXVyZW50LnBpbmNoYXJ0K3JlbmVzYXNAaWRlYXNv bmJvYXJkLmNvbT4KPiA+IC0tLQo+ID4gQ2hhbmdlcyBzaW5jZSB2MjoKPiA+IAo+ID4gLSBSZW5h bWUgdGhlIGZsYWcgdG8gRFJNX0JVU19GTEFHX0RBVEFfTFNCX1RPX01TQiBhbmQgYWRkIGEKPiA+ IAo+ID4gICBjb3JyZXNwb25kaW5nIERSTV9CVVNfRkxBR19EQVRBX01TQl9UT19MU0IgZmxhZy4K PiA+IAo+ID4gLS0tCj4gPiAKPiA+ICBpbmNsdWRlL2RybS9kcm1fY29ubmVjdG9yLmggfCA0ICsr KysKPiA+ICAxIGZpbGUgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspCj4gPiAKPiA+IGRpZmYgLS1n aXQgYS9pbmNsdWRlL2RybS9kcm1fY29ubmVjdG9yLmggYi9pbmNsdWRlL2RybS9kcm1fY29ubmVj dG9yLmgKPiA+IGluZGV4IGE5Yjk1MjQ2ZTI2ZS4uNzEyZjI1NTU3N2VhIDEwMDY0NAo+ID4gLS0t IGEvaW5jbHVkZS9kcm0vZHJtX2Nvbm5lY3Rvci5oCj4gPiArKysgYi9pbmNsdWRlL2RybS9kcm1f Y29ubmVjdG9yLmgKPiA+IEBAIC0xNjAsNiArMTYwLDEwIEBAIHN0cnVjdCBkcm1fZGlzcGxheV9p bmZvIHsKPiA+IAo+ID4gICNkZWZpbmUgRFJNX0JVU19GTEFHX1BJWERBVEFfUE9TRURHRQkoMTw8 MikKPiA+ICAvKiBkcml2ZSBkYXRhIG9uIG5lZy4gZWRnZSAqLwo+ID4gICNkZWZpbmUgRFJNX0JV U19GTEFHX1BJWERBVEFfTkVHRURHRQkoMTw8MykKPiA+IAo+ID4gKy8qIGRhdGEgaXMgdHJhbnNt aXR0ZWQgbXNiIHRvIGxzYiBvbiB0aGUgYnVzICovCj4gPiArI2RlZmluZSBEUk1fQlVTX0ZMQUdf REFUQV9NU0JfVE9fTFNCCSgxPDw0KQo+ID4gKy8qIGRhdGEgaXMgdHJhbnNtaXR0ZWQgbHNiIHRv IG1zYiBvbiB0aGUgYnVzICovCj4gPiArI2RlZmluZSBEUk1fQlVTX0ZMQUdfREFUQV9MU0JfVE9f TVNCCSgxPDw1KQo+IAo+IE5pdDogIkxTQiIgYW5kICJNU0IiIGJlY2F1c2UgdGhleSdyZSBhYmJy ZXZpYXRpb25zLiBJZiBJIGVuZCB1cCBhcHBseWluZwo+IHRoaXMgSSdsbCBwcm9iYWJseSBkbyB0 aGF0IG15c2VsZiwgYW5kIEkgbGVhdmUgaXQgdXAgdG8gd2hvZXZlciBlbHNlCj4gbWlnaHQgYXBw bHkgaXQgd2hldGhlciBvciBub3QgdGhleSB3YW50IHRvIGJlIHBlZGFudGljLCBzbzoKPiAKPiBS ZXZpZXdlZC1ieTogVGhpZXJyeSBSZWRpbmcgPHRyZWRpbmdAbnZpZGlhLmNvbT4KClRoYW5rIHlv dS4gSSdsbCBmaXggdGhhdCBpbiBteSB0cmVlIHRvby4gSSB3ZW50IGZvciBsb3dlciBjYXNlIGJl Y2F1c2UgYml0IGlzIAp1c3VhbGx5IGFiYnJldmlhdGVkIGIgYW5kIGJ5dGUgQiwgYnV0IEkgZG9u J3QgdGhpbmsgaXQgcmVhbGx5IGNvbnZleXMgdGhhdCAKbWVhbmluZyBhbnl3YXkgOi0pCgotLSAK UmVnYXJkcywKCkxhdXJlbnQgUGluY2hhcnQKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2RyaS1kZXZlbAo=