Re: [PATCH 33/39] reiserfs: split right balancing part of balance_leaf() off

[Jeff Mahoney <jeffm@suse.com>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Zan Lynx wrote:
> On Thu, 2007-06-07 at 18:01 -0400, Jeff Mahoney wrote:
>> Vladimir V. Saveliev wrote:
> [cut] 
>>> shouldn't function name prefixes be more consistent? Either bl_ or
>>> balance_leaf everywhere?
>>>
>> Yes, absolutely. Initially they were, but
>> balance_leaf_function_subfunction(parameter list) ended up with the
>> parameters grouped along the right margin. I wouldn't be opposed to
>> changing them all to bl_* except for balance_leaf itself.
> 
> Or you could trade vertical space for horizontal space and do like:
> 
> static void
> balance_leaf_right_paste_de_partial(
> 	struct tree_balance *tb, struct item_head *ih,
> 	const char *body, int flag, int *zeros_num,
> 	int item_pos, int *pos_in_item
> ) {
> 
> I always thought wasting all that horizontal space in parameter lists
> was silly just to save some vertical, and so many people get the
> tab-stop/space mix wrong.

Well, I actually meant with the call sites, where the start of the
funciton call is already two or three tab stops in. The next revision
uses bl_* for all of them.

- -Jeff

- --
Jeff Mahoney
SUSE Labs
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iD8DBQFGaLDXLPWxlyuTD7IRArMUAJ49r+82Hbj7TpHZOAIf3q1z3egV5ACeN+IH
iJroW0vmxIY1I6fiNDy/Dyg=
=p/e1
-----END PGP SIGNATURE-----