Re: [patch 2.6.22-rc4 8/7] mmc_spi cid/csd/ext_csd updates, CRCs on

[Pierre Ossman <drzeus-mmc-p3sGCRWkH8CeZLLa646FqQ@public.gmane.org>]

David Brownell wrote:
> Fix some of the "register"/descriptor access glitches in the
> preceding patches:
> 
>   - Updated internal routines:
>       * previous mmc_send_cxd() renamed to mmc_send_cxd_native(); it
>         uses native "R2" responses, which include 16 bytes of data.
>       * previous mmc_send_ext_csd() becomes new mmc_send_cxd_data()
>         helper for command-and-data access
> 
>   - Modified mmc_send_ext_csd() now uses mmc_send_cxd_data() helper
> 
>   - New mmc_send_csd() and mmc_spi_send_cid() routines now use one
>     of those helper routines based on whether they're native or SPI;
> 
>   - Remove ugly "R1D" response pseudo-type for SPI
> 
>   - Make it OK for MMC cards to try SEND_EXT_CSD; v4+ needs that
> 
>   - Turn CRCs back on by default with the SPI protocol
> 
> So this resolves most of the technical issues I know about, leaving
> nontechnical ones like "is this code clean enough" or "is this how
> we want to solve that problem".
> 
> Signed-off-by: David Brownell <dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>

Instead of me reviewing the broken set of patches, can you merge these fixes in
and resend the set?

Rgds
-- 
     -- Pierre Ossman

  Linux kernel, MMC maintainer        http://www.kernel.org
  PulseAudio, core developer          http://pulseaudio.org
  rdesktop, core developer          http://www.rdesktop.org

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/