From: Jeff Garzik <jeff@garzik.org>
To: Olof Johansson <olof@lixom.net>
Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH] [2.6.22] libata: fix probe time irq printouts
Date: Sat, 09 Jun 2007 22:42:04 -0400 [thread overview]
Message-ID: <466B64FC.1090509@garzik.org> (raw)
In-Reply-To: <20070603233510.GA25750@lixom.net>
Olof Johansson wrote:
> Most drivers don't seem to fill out the host->irq field, resulting in the
> wrong (no) irq being reported at probe time. For example, sil24 on my system:
>
> ata1: SATA max UDMA/100 cmd 0xd00008009001f000 ctl 0x0000000000000000 bmdma 0x0000000000000000 irq 0
> ata2: SATA max UDMA/100 cmd 0xd000080090021000 ctl 0x0000000000000000 bmdma 0x0000000000000000 irq 0
>
> Since they're allocated and set up in ata_host_activate(), just save
> them away there.
>
>
> Signed-off-by: Olof Johansson <olof@lixom.net>
>
>
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index af62514..7491b11 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -6438,6 +6438,9 @@ int ata_host_activate(struct ata_host *host, int irq,
> if (rc)
> devm_free_irq(host->dev, irq, host);
>
> + /* Used to print device info at probe */
> + host->irq = irq;
> +
applied, thanks for fixing that
prev parent reply other threads:[~2007-06-10 2:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-03 23:35 [PATCH] [2.6.22] libata: fix probe time irq printouts Olof Johansson
2007-06-10 2:42 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=466B64FC.1090509@garzik.org \
--to=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.