From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <htejun@gmail.com>
Cc: linux-ide@vger.kernel.org, calvin.walton@gmail.com,
alan@lxorguk.ukuu.org.uk
Subject: Re: [PATCH libata-dev#upstream-fixes] libata: force PIO on IOMEGA ZIP 250 ATAPI
Date: Mon, 11 Jun 2007 01:00:02 -0400 [thread overview]
Message-ID: <466CD6D2.403@garzik.org> (raw)
In-Reply-To: <20070610055236.GI29122@htj.dyndns.org>
Tejun Heo wrote:
> IOMEGA ZIP 250 ATAPI claims MWDMA0 support but fails SETXFERMODE if
> asked to configure itself to MWDMA0. Force PIO.
>
> This fixes bugzilla bug#8497.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> Cc: Calvin Walton <calvin.walton@gmail.com>
> ---
> There was another proposed patch which lowers transfer mode if device
> rejects transfer mode but I'm not sure whether that's the right thing
> to do. Such behavior change might affect other devices, so I'm opting
> for blacklisting for now.
>
> Thanks.
>
> drivers/ata/libata-core.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index 4733f00..6312a21 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -3769,6 +3769,7 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
> { "_NEC DV5800A", NULL, ATA_HORKAGE_NODMA },
> { "SAMSUNG CD-ROM SN-124","N001", ATA_HORKAGE_NODMA },
> { "Seagate STT20000A", NULL, ATA_HORKAGE_NODMA },
> + { "IOMEGA ZIP 250 ATAPI", NULL, ATA_HORKAGE_NODMA }, /* temporary fix */
applied, after adding the "temporary fix" comment based on Alan's comments
next prev parent reply other threads:[~2007-06-11 5:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-10 5:52 [PATCH libata-dev#upstream-fixes] libata: force PIO on IOMEGA ZIP 250 ATAPI Tejun Heo
2007-06-10 15:22 ` Alan Cox
2007-06-10 17:03 ` Bartlomiej Zolnierkiewicz
2007-06-11 5:00 ` Jeff Garzik [this message]
2007-06-11 5:07 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=466CD6D2.403@garzik.org \
--to=jeff@garzik.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=calvin.walton@gmail.com \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.