All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eduard-Gabriel Munteanu <maxdamage@aladin.ro>
To: Tejun Heo <htejun@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCHSET 2.6.22-rc4] sysfs: fix race conditions
Date: Mon, 11 Jun 2007 12:58:04 +0300	[thread overview]
Message-ID: <466D1CAC.6060307@aladin.ro> (raw)
In-Reply-To: <20070611050107.GJ29122@htj.dyndns.org>

*This message was transferred with a trial version of CommuniGate(r) Pro*
Tejun Heo wrote:

> This patchset contains three minimal backports of fixes in -mm.  With
> all patches in the patchset and sysfs-races.patch applied, kernel
> survived ~20 hours of stress test without any problem.
> 

Seriously, do you think adding a few sleeps fixes anything? It just 
makes it harder to happen, and even harder to debug, so this is no good. 
Race condition are fixed by proper locking, ordering and so on.

(No offence, this has to be the patch of the week. :) )

  parent reply	other threads:[~2007-06-11  9:57 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-11  5:01 [PATCHSET 2.6.22-rc4] sysfs: fix race conditions Tejun Heo
2007-06-11  5:02 ` [PATCH 1/3] sysfs: store sysfs inode nrs in s_ino to avoid readdir oopses Tejun Heo
2007-06-11  5:03 ` [PATCH 2/3] sysfs: fix condition check in sysfs_drop_dentry() Tejun Heo
2007-06-11  5:04 ` [PATCH 3/3] sysfs: fix race condition around sd->s_dentry, take#2 Tejun Heo
2007-06-11  6:12 ` [PATCHSET 2.6.22-rc4] sysfs: fix race conditions Andrew Morton
2007-06-11  6:15   ` Tejun Heo
2007-06-12  0:54     ` Greg KH
2007-06-12 23:47     ` Greg KH
2007-06-13  4:50       ` Tejun Heo
2007-06-11  9:58 ` Eduard-Gabriel Munteanu [this message]
2007-06-11 10:02   ` Tejun Heo
2007-06-11 10:14     ` Eduard-Gabriel Munteanu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=466D1CAC.6060307@aladin.ro \
    --to=maxdamage@aladin.ro \
    --cc=htejun@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.