From: "N. van Bolhuis" <nvbolhuis@aimsys.nl>
To: linuxppc-embedded@ozlabs.org
Subject: ioctl on 870 FEC causes "badness in local_bh_enable at kernel/softirq.c"
Date: Mon, 11 Jun 2007 17:44:43 +0200 [thread overview]
Message-ID: <466D6DEB.1030405@aimsys.nl> (raw)
I found a minor problem for the linux PPC PowerQuic_II FEC driver.
When doing an:
ioctl(.. SIOCGMIIREG ..) or
ioctl(.. SIOCSMIIREG ..)
the following kernel message pops up:
Badness in local_bh_enable at kernel/softirq.c:137
Call Trace:
[C102FC80] [C0008E04] (unreliable)
[C102FCA0] [C0003608]
[C102FCB0] [C0003EB0]
[C102FCD0] [C000310C]
[C102FD90] [C102FE40]
[C102FDA0] [C010794C]
[C102FDC0] [C01079C0]
[C102FDE0] [C010E7DC]
[C102FE00] [C01316C0]
[C102FE20] [C0132A08]
[C102FEA0] [C0126408]
[C102FEC0] [C0064B10]
[C102FEE0] [C0064F1C]
[C102FF10] [C0064F98]
[C102FF40] [C0002AC4]
This is because drivers/net/fs_enet/fs_enet-main.c:fs_ioctl
disables the interrupts with spin_lock_irqsave after which it calls
phy_mii_ioctl. This leads to drivers/net/phy/phy.c:phy_read
being called which does spin_lock_bh/spin_unlock_bh.
Obviously the spin_unlock_bh enables softirqs and it is correctly
complaining irqs are disabled.
fs_ioctl and phy_read are used by many others so I'm not sure
how to solve this. Therefore I ask this list.
Maybe fs_ioctl can use spin_(un)lock but I'm not sure.
Anybody has a fix or ideas about this ?
---
N. van Bolhuis.
--
This message has been scanned for viruses and is believed to be clean
next reply other threads:[~2007-06-11 15:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-11 15:44 N. van Bolhuis [this message]
2007-06-11 18:47 ` ioctl on 870 FEC causes "badness in local_bh_enable at kernel/softirq.c" Andy Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=466D6DEB.1030405@aimsys.nl \
--to=nvbolhuis@aimsys.nl \
--cc=linuxppc-embedded@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.