From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chris Lalancette <clalance@redhat.com>
Subject: [PATCH]: Fix fully-virtualized core dumps for 32-bit
	guests
Date: Mon, 11 Jun 2007 14:22:11 -0400
Message-ID: <466D92D3.1000407@redhat.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="------------030202070907010908000905"
Return-path: <xen-devel-bounces@lists.xensource.com>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

This is a multi-part message in MIME format.
--------------030202070907010908000905
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

All,
     Attached is a simple patch to fix core dumps for 32-bit guests running on
32-bit HV/dom0.  The problem ends up being a cast in the libxc dumping code;
basically in xc_core_x86.c, p2m_size is a ulong, and in the case of a 32-bit FV
guest 0xFFFFF is returned from xc_memory_op() in nr_gpfns.  However, 1 is then
added.  This means that when we are doing the map->size calculations, we have
0x100000 << 12, which yields 0, which is then stored in the uint64 map->size.
The simple fix is to cast p2m_size up to 64-bits first, then do the shift, then
store it into map->size.
     The patch is against xen-3.1, but should apply to current xen-unstable.

Signed-off-by: Chris Lalancette <clalance@redhat.com>

--------------030202070907010908000905
Content-Type: text/x-patch;
 name="xen-3.1-32bit-fv-core-dump.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="xen-3.1-32bit-fv-core-dump.patch"

diff -r c0b0974fb055 tools/libxc/xc_core_x86.c
--- a/tools/libxc/xc_core_x86.c	Fri May 18 16:59:32 2007 +0100
+++ b/tools/libxc/xc_core_x86.c	Mon Jun 11 14:18:19 2007 -0400
@@ -49,7 +49,7 @@ xc_core_arch_memory_map_get(int xc_handl
     }
 
     map->addr = 0;
-    map->size = p2m_size << PAGE_SHIFT;
+    map->size = ((uint64_t)p2m_size) << PAGE_SHIFT;
 
     *mapp = map;
     *nr_entries = 1;

--------------030202070907010908000905
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

--------------030202070907010908000905--