Re: [PATCH] Implement shrink of empty AGs

[Eric Sandeen <sandeen@sandeen.net>]

David Chinner wrote:
> On Sun, Jun 10, 2007 at 06:40:14PM +0200, Iustin Pop wrote:

...

>> +	/* FIXME: why is this flag unconditionally set in growfs? */
>> +	mp->m_flags |= XFS_MOUNT_32BITINODES;
>> +	nagimax = xfs_initialize_perag(XFS_MTOVFS(mp), mp, nagcount);

> good question. I don't think it should be there but I'll have to
> do some digging....


http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_fsops.c#rev1.72
Thu Dec 6 19:26:09 2001 UTC (5 years, 6 months ago) by lord
Add in the 32 bit inode mount flag before re initializing the perag
structures in growfs.
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_fsops.c.diff?r1=1.71;r2=1.72

but, it seems harmless because it immediately calls xfs_initialize_perag
which does:


        /* Clear the mount flag if no inode can overflow 32 bits
         * on this filesystem, or if specifically requested..
         */
        if ((mp->m_flags & XFS_MOUNT_32BITINOOPT) && ino > max_inum) {
                mp->m_flags |= XFS_MOUNT_32BITINODES;
        } else {
                mp->m_flags &= ~XFS_MOUNT_32BITINODES;
        }

so I think it sets it (or clears it) properly in any case.  I'd probably
remove the setting before initialize_perag though as it's superfluous...

that was added after steve's change...

http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_mount.c#rev1.335
Mon Sep 8 05:46:42 2003 UTC (3 years, 9 months ago) by nathans
Add inode64 mount option; fix case where growfs can push 32 bit inodes
into 64 bit space accidentally - both changes originally from IRIX
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_mount.c.diff?r1=1.334;r2=1.335

(previously it would always clear the flag if max inode was < 32 bits..)

... so yeah, looks like the setting in question can/should go.

-Eric