From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Hy8DW-0003Jp-8m for mharc-grub-devel@gnu.org; Tue, 12 Jun 2007 11:23:34 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Hy8DR-0003IV-Uh for grub-devel@gnu.org; Tue, 12 Jun 2007 11:23:30 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Hy8DQ-0003Hq-S1 for grub-devel@gnu.org; Tue, 12 Jun 2007 11:23:29 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Hy8DQ-0003He-M3 for grub-devel@gnu.org; Tue, 12 Jun 2007 11:23:28 -0400 Received: from relay.udl.es ([193.144.10.29] helo=relay3.udl.es) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Hy8DP-0002hv-R8 for grub-devel@gnu.org; Tue, 12 Jun 2007 11:23:28 -0400 Received: from jupiter.udl.net (jupiter.udl.net [172.16.2.2]) by relay3.udl.es (8.13.7/8.13.7) with ESMTP id l5CFN76a001937 for ; Tue, 12 Jun 2007 17:23:13 +0200 Received: from [172.16.51.20] (PL-CAP020.udl.net [172.16.51.20]) by jupiter.udl.net (8.11.7p1+Sun/8.11.6) with ESMTP id l5CFIxq21958 for ; Tue, 12 Jun 2007 17:19:03 +0200 (MET DST) Message-ID: <466EAADB.60209@raulete.net> Date: Tue, 12 Jun 2007 16:16:59 +0200 From: adrian15 User-Agent: Thunderbird 1.5.0.8 (X11/20061107) MIME-Version: 1.0 To: The development of GRUB 2 References: <466E8A36.7000104@raulete.net> <20070612143444.GD1754@aragorn> In-Reply-To: <20070612143444.GD1754@aragorn> Content-Type: text/plain; charset=UTF-8; format=flowed X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-3.0 (relay3.udl.es [10.69.4.19]); Tue, 12 Jun 2007 17:23:13 +0200 (CEST) X-Virus-Scanned: ClamAV 0.88.7/3407/Tue Jun 12 14:01:54 2007 on relay3.udl.es X-Virus-Status: Clean Content-Transfer-Encoding: quoted-printable X-MIME-Autoconverted: from 8bit to quoted-printable by relay3.udl.es id l5CFN76a001937 X-detected-kernel: Linux 2.6 (newer, 2) Subject: Re: Pager does work from a menu? X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Jun 2007 15:23:30 -0000 Robert Millan escribi=C3=B3: > On Tue, Jun 12, 2007 at 01:57:42PM +0200, adrian15 wrote: >> This code from: normal/command.c >> >> /* Enable the pager if the environment pager is set to 1. */ >> if (interactive) >> pager =3D grub_env_get ("pager"); >> else >> pager =3D 0; >> if (pager && (! grub_strcmp (pager, "1"))) >> grub_set_more (1); >> >> Can anyone confirm my suspictions that even the pager variable set to = 1 >> there is NO stop on the screen when running a grub option that has the >> cat command inside it with a big file? >=20 > Can you ellaborate? From the code you pasted, I just see that when > "interactive" is set to 0, this has the same effect as pager being set = to > the "0" string. That's what I mean. I think that interactive for grub2 means being in=20 the grub2 shell (not in a menu). If you are in a menu (non interactive)=20 then there is no stop between pages. But you know I am a bit lazy. I should at last try to do a grub.cfg and=20 test it on my test floppy and see if I am right or not. >> I am suspecting because in grub legacy there was the same stupid >> behaviour which I fixed of course. >> >> I also do not like the way that pager is run. I mean, putting a getkey >> inside the >> >> void >> grub_putcode (grub_uint32_t code) >> >> function from: kern/term.c >> >> it seems to me a bit childish although I do not know so far a better >> solution. >=20 > Please try to tear down that language! "stupid" and "childish" are in = general > not very appropiate words for a development list. Written down. Sorry, I'll try to use more formal synonims next time. >=20 > I suppose you're referring to: >=20 > grub_printf ("--MORE--"); > grub_setcolorstate (GRUB_TERM_COLOR_STANDARD); >=20 > key =3D grub_getkey (); >=20 > What do you find wrong in this code? AFAICS, the message is printed an= d then > we use grub_getkey to block untill a key is pressed. Sounds like norma= l > pager-ish behaviour to me.. The code is ok. What I do not find ok is that the screen pause happens=20 in a function which works it is to put a character on the screen. I do not quite understand why a function that only has to print a=20 character on the screen has also to deal with the screen by screen stop=20 problem. In my opinion this screen by screen stop problem should be solved in=20 another part of the source code but so far I do not know where. adrian15