All of lore.kernel.org
 help / color / mirror / Atom feed
From: Timur Tabi <timur@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH: cmdcfg: 00/19] Introduce initial versions of	new Command Config files.
Date: Tue, 12 Jun 2007 10:22:11 -0500	[thread overview]
Message-ID: <466EBA23.4030308@freescale.com> (raw)
In-Reply-To: <E1HxtkL-0002Be-K0@jdl.com>

Jon Loeliger wrote:

> This patch series implements a "temporary step" in
> which both the old and new configuration mechanism
> are still fully supported, but the old style using
> CFG_CMD_* is deprecated.  All references that used
> to exist with CFG_CMD_* are now duplicated to have
>     (CFG_CMD_x || CONFIG_CMD_x)

An alternative would have been to define CONFIG_COMMANDS based on the CONFIG_CMD_x values. 
   In cmd_confdefs.h, add something like this:

/* If CONFIG_COMMANDS is not defined, then assume we're using CONFIG_CMD_x */
#ifndef CONFIG_COMMANDS

#ifdef CONFIG_CMD_AUTOSCRIPT
#undef CONFIG_CMD_AUTOSCRIPT
#define CONFIG_CMD_AUTOSCRIPT CONFIG_CMD_AUTOSCRIPT
#else
#define CONFIG_CMD_AUTOSCRIPT 0
#endif

... ( repeat for each CONFIG_CMD_x )

#define CONFIG_COMMANDS \
	(CONFIG_CMD_AUTOSCRIPT | \
	CONFIG_CMD_x (repeat for each CONFIG_CMD_x)

#endif /* #ifndef CONFIG_COMMANDS */

With this technique, you won't need to modify all of the source files that use 
CONFIG_COMMANDS.

-- 
Timur Tabi
Linux Kernel Developer @ Freescale

  reply	other threads:[~2007-06-12 15:22 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-11 23:56 [U-Boot-Users] [PATCH: cmdcfg: 00/19] Introduce initial versions of new Command Config files Jon Loeliger
2007-06-12 15:22 ` Timur Tabi [this message]
2007-06-12 15:59   ` Wolfgang Denk
2007-06-12 16:07     ` Jon Loeliger
2007-06-12 16:08     ` Timur Tabi
2007-06-12 16:56       ` Wolfgang Denk
2007-06-12 17:41         ` Timur Tabi
2007-06-12 17:33 ` Ben Warren
2007-07-03 22:45 ` Wolfgang Denk
2007-07-05  0:59   ` Jon Loeliger
2007-07-05  1:43     ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=466EBA23.4030308@freescale.com \
    --to=timur@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.