From: Hans de Goede <j.w.r.degoede@hhs.nl>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] dme1737 and sch311x similarities
Date: Tue, 12 Jun 2007 17:40:30 +0000 [thread overview]
Message-ID: <466EDA8E.10009@hhs.nl> (raw)
In-Reply-To: <191fb4ca0706120929k2b63b7afy25e5e92b2dec756b@mail.gmail.com>
Juerg Haefliger wrote:
> All,
>
> I looked through the SMSC sch311x datasheet and discovered that the HW
> monitoring capabilities of the two chips are nearly identical. The
> sch311x is missing some of the optional features like fan4 and pwmA
> and pwmB and registers are accessed through the LPC interface rather
> than an SMBus interface as is the case for the dme1737.
> So if I were to enhance the dme1737 driver to support the sch311x
> family this would imply that sch311x owners would also need to load
> i2c modules which aren't really necessary/used in this case.
> On the other hand, two separate drivers means a lot of code redundancy...
>
> Any thoughts on which way to go? Personally I prefer a single driver,
> way easier to maintain.
>
I say go for the single driver approach,
Regards,
Hans
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2007-06-12 17:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-12 16:29 [lm-sensors] dme1737 and sch311x similarities Juerg Haefliger
2007-06-12 17:40 ` Hans de Goede [this message]
2007-06-14 18:37 ` Jean Delvare
2007-06-14 18:53 ` Juerg Haefliger
2007-06-15 18:25 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=466EDA8E.10009@hhs.nl \
--to=j.w.r.degoede@hhs.nl \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.