All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Richardson <mcr@sandelman.ca>
To: linux-ppp@vger.kernel.org
Subject: about that partial copy of radiusclient in pppd/plugins/radius
Date: Wed, 16 Jul 2014 02:04:33 +0000	[thread overview]
Message-ID: <4670.1405476273@sandelman.ca> (raw)


According to the git history on pppd, back in Nov. 14, 2004, radiusclient,
which had been imported into pppd, got merged so that only the critical
pieces were present.
   https://github.com/wkz/pppd/commit/4abe4296f0eddbb2b6ff11dbbd27100156c85f87

This was likely the right decision at the time.
The Freeradius folks picked up radiusclient see: http://freeradius.org/freeradius-client/
and https://github.com/FreeRADIUS/freeradius-client

I have need to add the IPv6 attributes, which means having ipv6addr and
ipv6prefix values, and adding decode support for that.

I'd rather not work on ancient code, yet the latest freeradius-client doesn't
have the support I need anyway.

It appears that there are the following differences:
        1) rc_handle on all calls; not much of a problem.
        2) use of pppd's error() call rather than rc_log(), I'm sure that
           I can work this out in the freeradius-client library with a
           pointer to function somewhere.
        3) some other stuff involving VENDOR_NONE and the like.
           It appears to be simple divergence.

My opinion is that freeradius-client does not need to compile to a .so,
that's it's better as a straight .a, most projects never need to install it,
just link it in.

My other opinion is that 99% of uses of pppd client ends, or are server ends
that do not use the radius plugin, and for the rest, it's not enough to have
libradiusclient.a, you need a bunch of /etc/*radiusclient/.. stuff too.
If I were packaging pppd for a distro, I'd make the radius part a seperate
package.  In git, I'd make the freeradius-client a submodule, and in tar.gz
form, I'd just document that you should extract freeradius-client.tgz "HERE"

Opinions?

--
]               Never tell me the odds!                 | ipv6 mesh networks [
]   Michael Richardson, Sandelman Software Works        | network architect  [
]     mcr@sandelman.ca  http://www.sandelman.ca/        |   ruby on rails    [



                 reply	other threads:[~2014-07-16  2:04 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4670.1405476273@sandelman.ca \
    --to=mcr@sandelman.ca \
    --cc=linux-ppp@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.