All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pierre Ossman <drzeus-list@drzeus.cx>
To: Linus Torvalds <torvalds@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: [GIT PULL] MMC updates
Date: Wed, 13 Jun 2007 19:24:44 +0200	[thread overview]
Message-ID: <4670285C.6070505@drzeus.cx> (raw)

Linus, please pull from

        git://git.kernel.org/pub/scm/linux/kernel/git/drzeus/mmc.git for-linus

to receive the following updates:

 drivers/mmc/core/sd.c   |   15 +++++++++++++++
 drivers/mmc/host/omap.c |   24 +++---------------------
 2 files changed, 18 insertions(+), 21 deletions(-)

Pierre Ossman (1):
      mmc: get back read-only switch function

Ragner Magalhaes (1):
      mmc-omap: fix sd response type 6 vs. 1

diff --git a/drivers/mmc/core/sd.c b/drivers/mmc/core/sd.c
index 41bfb5d..918477c 100644
--- a/drivers/mmc/core/sd.c
+++ b/drivers/mmc/core/sd.c
@@ -427,6 +427,21 @@ static int mmc_sd_init_card(struct mmc_host *host, u32 ocr,
                mmc_set_bus_width(host, MMC_BUS_WIDTH_4);
        }

+       /*
+        * Check if read-only switch is active.
+        */
+       if (!oldcard) {
+               if (!host->ops->get_ro) {
+                       printk(KERN_WARNING "%s: host does not "
+                               "support reading read-only "
+                               "switch. assuming write-enable.\n",
+                               mmc_hostname(host));
+               } else {
+                       if (host->ops->get_ro(host))
+                               mmc_card_set_readonly(card);
+               }
+       }
+
        if (!oldcard)
                host->card = card;

diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c
index 1914e65..b0824a3 100644
--- a/drivers/mmc/host/omap.c
+++ b/drivers/mmc/host/omap.c
@@ -522,28 +522,10 @@ static irqreturn_t mmc_omap_irq(int irq, void *dev_id)
                }

                if (status & OMAP_MMC_STAT_CARD_ERR) {
-                       if (host->cmd && host->cmd->opcode ==
MMC_STOP_TRANSMISSION) {
-                               u32 response = OMAP_MMC_READ(host, RSP6)
-                                       | (OMAP_MMC_READ(host, RSP7) << 16);
-                               /* STOP sometimes sets must-ignore bits */
-                               if (!(response & (R1_CC_ERROR
-                                                               | R1_ILLEGAL_COMMAND
-                                                               |
R1_COM_CRC_ERROR))) {
-                                       end_command = 1;
-                                       continue;
-                               }
-                       }
-
-                       dev_dbg(mmc_dev(host->mmc), "card status error (CMD%d)\n",
+                       dev_dbg(mmc_dev(host->mmc),
+                               "ignoring card status error (CMD%d)\n",
                                host->cmd->opcode);
-                       if (host->cmd) {
-                               host->cmd->error = MMC_ERR_FAILED;
-                               end_command = 1;
-                       }
-                       if (host->data) {
-                               host->data->error = MMC_ERR_FAILED;
-                               transfer_error = 1;
-                       }
+                       end_command = 1;
                }

                /*

-- 
     -- Pierre Ossman

  Linux kernel, MMC maintainer        http://www.kernel.org
  PulseAudio, core developer          http://pulseaudio.org
  rdesktop, core developer          http://www.rdesktop.org

             reply	other threads:[~2007-06-13 17:23 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-13 17:24 Pierre Ossman [this message]
  -- strict thread matches above, loose matches on Subject: below --
2008-04-19  7:28 [GIT PULL] MMC updates Pierre Ossman
2008-02-09  9:50 Pierre Ossman
2007-12-12 19:12 Pierre Ossman
2007-12-18  7:57 ` Pierre Ossman
2007-11-21 17:56 Pierre Ossman
2007-10-17 20:44 Pierre Ossman
2007-10-17 20:48 ` Dan Williams
2007-10-10 19:21 Pierre Ossman
2007-10-12  5:30 ` Linus Torvalds
2007-10-12  5:45   ` Pierre Ossman
2007-10-12 12:18     ` Kay Sievers
2007-10-12 13:53       ` Pierre Ossman
2007-10-12 19:55   ` Pierre Ossman
2007-10-12 20:05     ` Nicolas Pitre
2007-10-12 20:35       ` Pierre Ossman
2007-10-12 21:00       ` Pierre Ossman
2007-10-13  5:29         ` Randy Dunlap
2007-10-13  7:03           ` Pierre Ossman
2007-09-11 15:26 Pierre Ossman
2007-08-23  5:18 Pierre Ossman
2007-08-09 14:34 Pierre Ossman
2007-07-26 13:15 Pierre Ossman
2007-07-21  0:36 Pierre Ossman
2007-07-10 20:43 Pierre Ossman
2007-06-08  8:09 Pierre Ossman
2007-05-24  5:46 Pierre Ossman
2007-05-14 16:55 Pierre Ossman
2007-05-08 20:45 Pierre Ossman
2007-05-09  5:55 ` Pierre Ossman
2007-05-09  6:03   ` Nick Piggin
2007-05-09  6:27     ` Pierre Ossman
2007-05-09  6:35       ` Nick Piggin
2007-05-09  7:51         ` Pierre Ossman
2007-05-09  8:05           ` Nick Piggin
2007-05-09  9:11           ` Stefan Richter
2007-05-09 15:44             ` Pierre Ossman
2007-05-01 15:22 Pierre Ossman
2007-05-05  4:24 ` Pierre Ossman
2007-05-05  4:45   ` Linus Torvalds
2007-05-09 18:56 ` Russell King
2007-05-09 19:06   ` Pierre Ossman
2007-05-09 22:12     ` Russell King
2007-05-10  5:44       ` Pierre Ossman
2007-05-10  7:51         ` Russell King
2007-05-10 13:58         ` Pierre Ossman
2007-05-10 14:52           ` Nicolas Pitre
2007-05-12 15:38             ` Nicolas Pitre
2007-05-12 16:12               ` Pierre Ossman
2007-05-12 16:22                 ` Russell King
2007-05-12 17:55                   ` Nicolas Pitre
2007-02-11 15:33 Pierre Ossman
2007-02-04 20:11 Pierre Ossman
2007-01-15  5:46 Pierre Ossman
2007-01-04 12:49 Pierre Ossman
2007-01-10 19:51 ` Pierre Ossman
2006-12-11 11:45 Pierre Ossman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4670285C.6070505@drzeus.cx \
    --to=drzeus-list@drzeus.cx \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.