From: Jeff Garzik <jeff@garzik.org>
To: bryan.wu@analog.com
Cc: LKML <linux-kernel@vger.kernel.org>,
netdev@vger.kernel.org, torvalds@linux-foundation.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] Blackfin ethernet driver: on chip ethernet MAC controller driver
Date: Wed, 13 Jun 2007 15:39:45 -0400 [thread overview]
Message-ID: <46704801.1070107@garzik.org> (raw)
In-Reply-To: <1179912533.10328.26.camel@roc-desktop>
Bryan Wu wrote:
> From: "Wu, Bryan" <bryan.wu@analog.com>
>
> This patch implements the driver necessary use the Analog Devices
> Blackfin processor's on-chip ethernet MAC controller.
>
> Signed-off-by: Bryan Wu <bryan.wu@analog.com>
> Cc: Jeff Garzik <jeff@garzik.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
>
> drivers/net/Kconfig | 44 +
> drivers/net/Makefile | 1
> drivers/net/bfin_mac.c | 981 +++++++++++++++++++++++++++++++++++++++
> drivers/net/bfin_mac.h | 147 +++++
> 4 files changed, 1173 insertions(+)
Finally got back to this. Please run this patch through
scripts/checkpatch.pl (found in latest linux-2.6.git upstream kernel
tree), and follow most of the recommendations.
Personally I would ignore the lines slightly over 80 columns, but the
other warnings look like real issues.
Jeff
prev parent reply other threads:[~2007-06-13 19:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-23 9:28 [PATCH] Blackfin ethernet driver: on chip ethernet MAC controller driver Bryan Wu
2007-06-13 19:39 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46704801.1070107@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@linux-foundation.org \
--cc=bryan.wu@analog.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.