From: Tejun Heo <htejun@gmail.com>
To: Kristen Carlson Accardi <kristen.c.accardi@intel.com>
Cc: Pavel Machek <pavel@ucw.cz>,
Arjan van de Ven <arjan@linux.intel.com>,
jeff@garzik.org, james.bottomley@steeleye.com,
linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org, Jens Axboe <jens.axboe@oracle.com>
Subject: Re: [patch 0/3] AHCI Link Power Management
Date: Thu, 14 Jun 2007 16:56:43 +0900 [thread overview]
Message-ID: <4670F4BB.3060306@gmail.com> (raw)
In-Reply-To: <20070613092607.4ddf0f79.kristen.c.accardi@intel.com>
Kristen Carlson Accardi wrote:
>>>>> I'm not sure about this. We need better PM framework to support
>>>>> powersaving in other controllers and some ahcis don't save much
>>>>> when only link power management is used,
>>>> do you have data to support this?
>>> Yeah, it was some Lenovo notebook. Pavel is more familiar with the
>>> hardware. Pavel, what was the notebook which didn't save much power
>>> with standard SATA power save but needed port to be completely turned off?
>> Thinkpad x60. Some one Kristen probably used while developing the
>> patch :-).
>
> Yes - that confirms my conclusion that the first patch just wasn't
> done correctly - cause when I measure the power savings with a power
> meter on the X60 with my patches I see ~ 1W.
Hmmm... Could it be that the controller doesn't enter powersave state
when SControl is written to?
--
tejun
next prev parent reply other threads:[~2007-06-14 7:56 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-11 18:46 [patch 0/3] AHCI Link Power Management Kristen Carlson Accardi
2007-06-12 1:58 ` Tejun Heo
2007-06-12 2:33 ` Jeff Garzik
2007-06-12 2:34 ` Arjan van de Ven
2007-06-12 3:12 ` Jeff Garzik
2007-06-12 3:12 ` Arjan van de Ven
2007-06-12 3:18 ` Jeff Garzik
2007-06-12 4:13 ` Tejun Heo
2007-06-12 4:19 ` Arjan van de Ven
2007-06-12 4:40 ` Tejun Heo
2007-06-12 15:56 ` Kristen Carlson Accardi
2007-06-12 4:43 ` Jeff Garzik
2007-06-12 15:43 ` Kristen Carlson Accardi
2007-06-13 14:51 ` Pavel Machek
2007-06-13 9:04 ` Pavel Machek
2007-06-13 16:26 ` Kristen Carlson Accardi
2007-06-14 7:56 ` Tejun Heo [this message]
2007-06-13 14:56 ` Pavel Machek
2007-06-14 11:56 ` Jens Axboe
2007-06-14 12:30 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4670F4BB.3060306@gmail.com \
--to=htejun@gmail.com \
--cc=arjan@linux.intel.com \
--cc=james.bottomley@steeleye.com \
--cc=jeff@garzik.org \
--cc=jens.axboe@oracle.com \
--cc=kristen.c.accardi@intel.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.