All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Gundersen <gundy@iinet.net.au>
To: netdev@vger.kernel.org
Subject: Re: r8169 tx problem (1s pause with ping)
Date: Fri, 15 Jun 2007 01:33:14 +1000	[thread overview]
Message-ID: <46715FBA.3070302@iinet.net.au> (raw)
In-Reply-To: <20070613211859.GA22521@electric-eye.fr.zoreil.com>

[-- Attachment #1: Type: text/plain, Size: 1717 bytes --]

Francois Romieu wrote:
> Benjamin LaHaise <bcrl@kvack.org> :
> [...]
>> I'm seeing something odd with r8169 on FC7: doing a ping -s 1600 alternates 
>> between a 1s latency and sub 1ms.  Has anyone else seen anything like this?  
>> The system in question is an Asus M2A-VM with an onboard RTL8111 (I think).  
>> NAPI doesn't seem to make a difference.  The kernel in question is currently 
>> a vanilla 2.6.21.5.  Sub-mtu sized packets behave normally.
> 
> Same thing here for my 8168 rev 01 (asrock 945G dvi LOM) with 2.6.22-rc4
> and 2.6.22-rc3 + r816x patchkit.
> 
> Wonderful.
> 

I've got a modified version of the latest realtek (r8168) driver running 
here that doesn't seem to exhibit those symptoms.

The trouble I have is that I've been playing with multiple sections of 
the code and I'm not 100% sure what part(s) might impact that particular 
test.  The bits I know I've messed with are the bits that set the 
First/Last fragment flags and the NPQ flagging section (as described in 
my previous emails).

I know it's not particularly scientific of me to be changing multiple 
sections of the driver at once and I'm sorry about that but it's fairly 
late here and I really should get some sleep :).  I might do some more 
thorough testing on the weekend to find out what the minimal changes 
required are to get things working.

In the mean-time I'll attach my patch for the r8168-8.001.00 realtek 
driver here in case anybody else wants to have a play with it and see if 
it helps them out.

Also, It might be a silly question, but have you tried taking packet 
captures from the perspective of the box with the realtek chipset & 
another box during the pinging and comparing the two?

Regards,
Dave.

[-- Attachment #2: r8168-8.001.00-dg.patch.gz --]
[-- Type: application/x-gzip, Size: 2237 bytes --]

  reply	other threads:[~2007-06-14 15:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-13  0:41 r8169 tx problem (1s pause with ping) Benjamin LaHaise
2007-06-13 21:18 ` Francois Romieu
2007-06-14 15:33   ` David Gundersen [this message]
2007-06-14 22:00     ` Francois Romieu
2007-06-19 23:06       ` Francois Romieu
2007-06-20  8:57         ` David Gundersen
2007-06-20 21:15           ` Francois Romieu
2007-06-18 15:14     ` Benjamin LaHaise
2007-06-19 10:45       ` David Gundersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46715FBA.3070302@iinet.net.au \
    --to=gundy@iinet.net.au \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.