From: Jeff Garzik <jeff@garzik.org>
To: Stephen Hemminger <shemminger@linux-foundation.org>
Cc: James Ketrenos <jketreno@linux.intel.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] iwlwifi MSI support (rev3)
Date: Thu, 14 Jun 2007 14:52:42 -0400 [thread overview]
Message-ID: <46718E7A.6090001@garzik.org> (raw)
In-Reply-To: <20070614114809.39106c17@localhost>
Stephen Hemminger wrote:
> The previous patch would crash on remove. pci_disable_msi has to be
> called after free_irq. FYI - pci_disable_msi is safe if MSI hasn't been
> enabled.
>
> --- a/drivers/net/wireless/mac80211/iwlwifi/base.c 2007-06-13 11:10:10.000000000 -0700
> +++ b/drivers/net/wireless/mac80211/iwlwifi/base.c 2007-06-14 11:47:01.000000000 -0700
> @@ -8117,10 +8117,13 @@ static int iwl_pci_probe(struct pci_dev
> /* If power management is turned on, default to AC mode */
> priv->power_mode = IWL_POWER_AC;
> priv->user_txpower_limit = IWL_DEFAULT_TX_POWER;
> +
> + pci_enable_msi(pdev);
The API wants fixing, if code that fails to check return value of
pci_enable_msi() is being written.
We should definitely be checking the return value there...
Jeff
next prev parent reply other threads:[~2007-06-14 18:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-14 18:48 [PATCH] iwlwifi MSI support (rev3) Stephen Hemminger
2007-06-14 18:52 ` Jeff Garzik [this message]
2007-06-14 20:17 ` Stephen Hemminger
2007-06-14 22:47 ` Stephen Hemminger
2007-06-14 23:02 ` Jeff Garzik
2007-06-15 0:11 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46718E7A.6090001@garzik.org \
--to=jeff@garzik.org \
--cc=jketreno@linux.intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.