From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Ferre Subject: Re: [PATCH] atmel_lcdfb: Fix wrong line_length calculation Date: Fri, 15 Jun 2007 10:49:11 +0200 Message-ID: <46725287.7020702@rfo.atmel.com> References: <1179511541.3811.16.camel@bender> <1181647677482-git-send-email-hskinnemoen@atmel.com> Reply-To: linux-fbdev-devel@lists.sourceforge.net Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from sc8-sf-mx2-b.sourceforge.net ([10.3.1.92] helo=mail.sourceforge.net) by sc8-sf-list1-new.sourceforge.net with esmtp (Exim 4.43) id 1Hz7Vz-0004cI-No for linux-fbdev-devel@lists.sourceforge.net; Fri, 15 Jun 2007 01:50:43 -0700 Received: from mail.atmel.fr ([81.80.104.162] helo=atmel-es2.atmel.fr) by mail.sourceforge.net with esmtp (Exim 4.44) id 1Hz7Vy-0003eL-0G for linux-fbdev-devel@lists.sourceforge.net; Fri, 15 Jun 2007 01:50:43 -0700 In-Reply-To: <1181647677482-git-send-email-hskinnemoen@atmel.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-fbdev-devel-bounces@lists.sourceforge.net Errors-To: linux-fbdev-devel-bounces@lists.sourceforge.net To: Haavard Skinnemoen , "Antonino A. Daplas" Cc: Patrice Vilchez , Andrew Victor , linux-fbdev-devel@lists.sourceforge.net, Linux Kernel list Haavard Skinnemoen : > As Jan Altenberg pointed out, line_length will always be 0 if > bits_per_pixel < 8. Fix this and also make sure that we round up to > the nearest byte. > > Signed-off-by: Haavard Skinnemoen > --- > I haven't tested this with any real program that uses the frame buffer, > but fbset seems to report sane values for line_length: Thank you Haavard. I have a bigger patch for all the support for STN display (tested with mono STN display). It is based on the work from Jan Altenberg. This bigger patch includes your modifications. I send it right now. As a separate message. Haavard, can you check if the compute_hozval() function is ok on avr32 (I have reviewed with the at32ap7000 and hope that it is ok) ? Regards, -- Nicolas Ferre ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753425AbXFOI57 (ORCPT ); Fri, 15 Jun 2007 04:57:59 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751381AbXFOI5v (ORCPT ); Fri, 15 Jun 2007 04:57:51 -0400 Received: from mail.atmel.fr ([81.80.104.162]:55571 "EHLO atmel-es2.atmel.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750861AbXFOI5u (ORCPT ); Fri, 15 Jun 2007 04:57:50 -0400 X-Greylist: delayed 446 seconds by postgrey-1.27 at vger.kernel.org; Fri, 15 Jun 2007 04:57:46 EDT Message-ID: <46725287.7020702@rfo.atmel.com> Date: Fri, 15 Jun 2007 10:49:11 +0200 From: Nicolas Ferre Organization: atmel User-Agent: Thunderbird 1.5.0.12 (Windows/20070509) MIME-Version: 1.0 To: Haavard Skinnemoen , "Antonino A. Daplas" CC: linux-fbdev-devel@lists.sourceforge.net, Andrew Victor , Linux Kernel list , Jan Altenberg , Patrice Vilchez Subject: Re: [PATCH] atmel_lcdfb: Fix wrong line_length calculation References: <1179511541.3811.16.camel@bender> <1181647677482-git-send-email-hskinnemoen@atmel.com> In-Reply-To: <1181647677482-git-send-email-hskinnemoen@atmel.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-ESAFE-STATUS: Mail clean X-ESAFE-DETAILS: Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Haavard Skinnemoen : > As Jan Altenberg pointed out, line_length will always be 0 if > bits_per_pixel < 8. Fix this and also make sure that we round up to > the nearest byte. > > Signed-off-by: Haavard Skinnemoen > --- > I haven't tested this with any real program that uses the frame buffer, > but fbset seems to report sane values for line_length: Thank you Haavard. I have a bigger patch for all the support for STN display (tested with mono STN display). It is based on the work from Jan Altenberg. This bigger patch includes your modifications. I send it right now. As a separate message. Haavard, can you check if the compute_hozval() function is ok on avr32 (I have reviewed with the at32ap7000 and hope that it is ok) ? Regards, -- Nicolas Ferre