Re: [RFC] memory unplug v5 [5/6] page unplug

[Andy Whitcroft <apw@shadowen.org>]

Christoph Lameter wrote:
> On Thu, 14 Jun 2007, David Rientjes wrote:
> 
>>> +	struct zone *zone = NULL;
>>> +	struct page *page;
>>> +	for (pfn = start_pfn;
>>> +             pfn < end_pfn;
>>> +	     pfn += MAX_ORDER_NR_PAGES) {
>>> +#ifdef CONFIG_HOLES_IN_ZONE
>>> +		int i;
>>> +		for (i = 0; i < MAX_ORDER_NR_PAGES; i++) {
>>> +			if (pfn_valid_within(pfn + i))
>>> +				break;
>>> +		}
>>> +		if (i == MAX_ORDER_NR_PAGES)
>>> +			continue;
>>> +		page = pfn_to_page(pfn + i);
>>> +#else
>>> +		page = pfn_to_page(pfn);
>>> +#endif
>> Please extract this out to inlined functions that are conditional are 
>> CONFIG_HOLES_IN_ZONE.
> 
> And we need to deal with HOLES_IN_ZONE because the sparsemem virtual 
> memmap patchset was not merged and therefore we cannot get rid of 
> VIRTUAL_MEM_MAP.
> 
> Andy, any progress? Do you want me to do another patchset?

I believe I've got the latest.  I'll sort out the feedback over the
weekend and get a new patchset out, to Andrew.

-apw

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>