All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jaco Kroon <jaco@kroon.co.za>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH] Centralize checking for adequate version of gcc.
Date: Fri, 15 Jun 2007 15:57:36 +0000	[thread overview]
Message-ID: <4672B6F0.2010706@kroon.co.za> (raw)
In-Reply-To: <Pine.LNX.4.64.0706150650010.25667@localhost.localdomain>

Robert P. J. Day wrote:
> On Fri, 15 Jun 2007, Vegard Nossum wrote:
> 
>> On 6/15/07, Robert P. J. Day <rpjday@mindspring.com> wrote:
>>>   here's a patch i submitted to andrew to centralize checking for a
>>> proper version of gcc when building the kernel, but andrew claims it
>>> broke the build.  i'm trying to reproduce the problem, and i'd
>>> appreciate it if anyone else wants to apply this patch and try a build
>>> based on "allyesconfig" or "allmodconfig" on x86 to see if they run
>>> into some kind of issue, cuz i'm just not seeing it here.  thanks.
>> It works for me (using gcc 4.1.1 for i386 on linus's tree). Removing
>> that explanatory comment is not very nice, though.
> 
> which explanatory comment?  the one from init/main.c?  but why would i
> leave it in when the code it pertains to has been removed?

Move the comment perhaps?
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors

  parent reply	other threads:[~2007-06-15 15:57 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-15 10:52 [KJ] [PATCH] Centralize checking for adequate version of gcc Robert P. J. Day
2007-06-15 13:43 ` Vegard Nossum
2007-06-15 15:42 ` Robert P. J. Day
2007-06-15 15:57 ` Vegard Nossum
2007-06-15 15:57 ` Jaco Kroon [this message]
2007-06-15 16:39 ` Robert P. J. Day
2007-06-15 16:47 ` Jaco Kroon
2007-06-15 17:12 ` burns.ethan
2007-06-15 18:39 ` Robert P. J. Day
2007-06-20 21:38 ` Adrian Bunk
2007-06-20 21:53 ` Matthew Wilcox
2007-06-20 22:07 ` Robert P. J. Day
2007-06-21  5:19 ` Jaco Kroon
2007-06-21 12:00 ` Robert P. J. Day
2007-06-21 13:46 ` Alexey Dobriyan
2007-06-21 16:04 ` Robert P. J. Day
2007-06-21 18:37 ` Alexey Dobriyan
2007-06-22 19:29 ` Thomas De Schampheleire

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4672B6F0.2010706@kroon.co.za \
    --to=jaco@kroon.co.za \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.