Re: [dpdk-dev] [dpdk-stable] [PATCH 3/3] ipc: add warnings about correct API usage

[Thomas Monjalon <thomas@monjalon.net>]

03/05/2019 13:50, Anatoly Burakov:
> When handling synchronous or asynchronous requests, the reply
> must be sent explicitly even if the result of the operation is
> an error, to avoid the other side timing out. Make note of this
> in documentation explicitly.
> 
> Cc: stable@dpdk.org
> 
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---
> --- a/lib/librte_eal/common/include/rte_eal.h
> +++ b/lib/librte_eal/common/include/rte_eal.h
> @@ -226,6 +226,11 @@ struct rte_mp_reply {
>   * As we create  socket channel for primary/secondary communication, use
>   * this function typedef to register action for coming messages.
>   *
> + * @note When handling IPC request callbacks, the reply must be sent even in
> + *   cases of error handling. Simply retuning success or failure will *not* send

retuning -> returning
Will fix on apply.