From: Anand Jain <anand.jain@oracle.com>
To: dsterba@suse.cz
Cc: linux-btrfs@vger.kernel.org, dsterba@suse.com
Subject: Re: [PATCH 2/5] btrfs-progs: tune use the latest bdev in fs_devices for super_copy
Date: Tue, 29 Aug 2023 06:43:22 +0800 [thread overview]
Message-ID: <4673690d-c5d5-c40a-ada4-d55bc515c3cf@oracle.com> (raw)
In-Reply-To: <20230828152729.GB14420@twin.jikos.cz>
Currently, btrfstune relies on the superblock of the device specified
in the btrfstune argument for fs_info::super_copy. However, it should
use fs_devices::latest_bdev, as it points to the device with the highest
fs_devices::generation number. This will contain the superblock updates
that other devices may have missed and we can now support reuniting
devices following failures of btrfstune -m|M|u|U as in the patches:
btrfs-progs: add support to fix superblock with CHANGING_FSID_V2 flag
btrfs-progs: recover from the failed btrfstune -m|M
> This lacks explanatni why it should use it, it's not obvious.
Could you please use the commit log above, or let me know
if a reroll is preferred?
Thanks, Anand
next prev parent reply other threads:[~2023-08-28 22:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-25 14:47 [PATCH 0/5 v3] btrfs-progs: recover from failed metadata_uuid port kernel Anand Jain
2023-08-25 14:47 ` [PATCH 1/5] btrfs-progs: cleanup duplicate check metadata_uuid flag Anand Jain
2023-08-28 15:28 ` David Sterba
2023-08-25 14:47 ` [PATCH 2/5] btrfs-progs: tune use the latest bdev in fs_devices for super_copy Anand Jain
2023-08-28 15:27 ` David Sterba
2023-08-28 22:43 ` Anand Jain [this message]
2023-08-25 14:47 ` [PATCH 3/5] btrfs-progs: add support to fix superblock with CHANGING_FSID_V2 flag Anand Jain
2023-08-25 14:47 ` [PATCH 4/5] btrfs-progs: recover from the failed btrfstune -m|M Anand Jain
2023-08-25 14:47 ` [PATCH 5/5] btrfs-progs: test btrfstune -m|M ability to fix previous failures Anand Jain
2023-08-28 15:31 ` [PATCH 0/5 v3] btrfs-progs: recover from failed metadata_uuid port kernel David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4673690d-c5d5-c40a-ada4-d55bc515c3cf@oracle.com \
--to=anand.jain@oracle.com \
--cc=dsterba@suse.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.