From: Tejun Heo <htejun@gmail.com>
To: albertl@mail.com
Cc: Linux IDE <linux-ide@vger.kernel.org>,
Doug Maxey <dwm@enoyolf.org>, Mikael Pettersson <mikpe@it.uu.se>
Subject: Re: [PATCH/RFC 7/9] libata: pdc_freeze() semantic change
Date: Mon, 18 Jun 2007 14:14:55 +0900 [thread overview]
Message-ID: <467614CF.5070006@gmail.com> (raw)
In-Reply-To: <467207BF.9020409@tw.ibm.com>
Albert Lee wrote:
> Patch 7/9:
>
> After checking the current implementations of freeze()/thaw(), it seems only pdc_freeze()
> do more than simple irq masking. Remove the DMA disable code from pdc_freeze().
>
> The question is the design/semantic of freeze()/thaw().
> Maybe we should limit them to simple irq on/off?
Yeap, we can do that but if we do so it would be better to use
->irq_off/->irq_on hooks and kill ->freeze/->thaw.
--
tejun
next prev parent reply other threads:[~2007-06-18 5:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-15 3:11 [PATCH/RFC 0/9] libata: irq_on/off restructuring Albert Lee
2007-06-15 3:15 ` [PATCH/RFC 1/9] libata: remove irq_on from ata_bus_reset() and ata_std_postreset() Albert Lee
2007-06-15 3:17 ` [PATCH/RFC 2/9] libata: add irq_off() for symmetry Albert Lee
2007-06-15 3:19 ` [PATCH/RFC 3/9] libata: add ->irq_off() to LLDDs Albert Lee
2007-06-15 3:21 ` [PATCH/RFC 4/9] libata: call irq_off from bmdma_freeze() Albert Lee
2007-06-15 3:24 ` [PATCH/RFC 5/9] libata: use freeze()/thaw() for polling Albert Lee
2007-06-18 5:13 ` Tejun Heo
2007-06-15 3:26 ` [PATCH/RFC 6/9] libata: add freeze()/thaw() to old EH LLDDs Albert Lee
2007-06-15 3:30 ` [PATCH/RFC 7/9] libata: pdc_freeze() semantic change Albert Lee
2007-06-18 5:14 ` Tejun Heo [this message]
2007-06-15 3:34 ` [PATCH/RFC 8/9] libata: remove writing of tf->ctl from ata_tf_load() Albert Lee
2007-06-15 3:44 ` [PATCH/RFC 9/9] libata: remove irq_on/off and rename freeze()/thaw() to irq_on/off Albert Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=467614CF.5070006@gmail.com \
--to=htejun@gmail.com \
--cc=albertl@mail.com \
--cc=dwm@enoyolf.org \
--cc=linux-ide@vger.kernel.org \
--cc=mikpe@it.uu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.