Re: [PATCH 3/3] zfcp: Don't report device as LUN 0 to SCSI stack

[Hannes Reinecke <hare@suse.de>]

James Bottomley wrote:
> On Tue, 2007-05-29 at 15:29 +0200, Swen Schillig wrote: 
>> From: Christof Schmitt <schmichr@de.ibm.com>
>>
>> zfcp reported units to the SCSI stack starting
>> with number 0. LUN 0 reported to the SCSI stack is usually 
>> not the FCP LUN 0. When scanning for devices, 
>> the SCSI stack tried to issue a REPORT LUN command to LUN 0. 
>> The current design for zfcp does not want the SCSI stack to scan
>> for devices, since they are configured explicitly via sysfs.
>> This patch changes the numbering to always start with LUN 1 and therefore
>> prevent the SCSI stack sending REPORT LUN command.
> 
> As a general principle, this does sound to be wrong (at least shifting
> the LUNs).  Wouldn't something like the existing blacklist preventing
> the REPORT LUN command from being sent be more appropriate?
> 
IMO the zfcp driver should export the FCP LUNs and not building their
own internal SCSI LUN to FCP LUN mapping table.
That would avoid this issue, too. And would make the zfcp driver more in
line with everyone else ...

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Markus Rex, HRB 16746 (AG Nürnberg)
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html