Re: [PATCH 5/5] KVM: paravirt time source

[Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>]

Anthony Liguori wrote:
> +static int kvm_hypercall_get_ktime(struct kvm_vcpu *vcpu, gva_t va)
> +{
> +	struct timespec now;
> +	int ret;
> +
> +	ktime_get_ts(&now);
> +
> +	ret = kvm_write_guest(vcpu, va, sizeof(now), &now);
> +	if (unlikely(ret))
> +		return -EFAULT;
> +
> +	return 0;
> +}

Please use physical addresses (much faster, less possibility of 
confusion).  struct kvm_timespec instead of timespec. KVM_EFAULT instead 
of EFAULT.



-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/