From: Patrick McHardy <kaber@trash.net>
To: "Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@intel.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, jeff@garzik.org,
"Kok, Auke-jan H" <auke-jan.h.kok@intel.com>,
hadi@cyberus.ca
Subject: Re: [PATCH 3/3] NET: [CORE] Stack changes to add multiqueue hardware support API
Date: Mon, 18 Jun 2007 22:28:46 +0200 [thread overview]
Message-ID: <4676EAFE.8040601@trash.net> (raw)
In-Reply-To: <D5C1322C3E673F459512FB59E0DDC329030D596A@orsmsx414.amr.corp.intel.com>
Waskiewicz Jr, Peter P wrote:
>
>>> /* Functions used for multicast support */ diff --git
>>> a/include/linux/skbuff.h b/include/linux/skbuff.h index
>>> e7367c7..8bcd870 100644
>>> --- a/include/linux/skbuff.h
>>> +++ b/include/linux/skbuff.h
>>> @@ -215,6 +215,7 @@ typedef unsigned char *sk_buff_data_t;
>>> * @pkt_type: Packet class
>>> * @fclone: skbuff clone status
>>> * @ip_summed: Driver fed us an IP checksum
>>> + * @queue_mapping: Queue mapping for multiqueue devices
>>> * @priority: Packet queueing priority
>>> * @users: User count - see {datagram,tcp}.c
>>> * @protocol: Packet protocol from driver
>>> @@ -269,6 +270,7 @@ struct sk_buff {
>>> __u16 csum_offset;
>>> };
>>> };
>>> + __u16 queue_mapping;
>>>
>>>
>> We have a 4 byte hole on 64 bit after iif where this would fit in.
>>
>
> I'll move the variable. Thanks for this!
>
Or maybe move iif down to queue_mapping so both are near the
queueing related stuff.
next prev parent reply other threads:[~2007-06-18 20:28 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-18 18:42 [PATCH] NET: Multiple queue hardware support PJ Waskiewicz
2007-06-18 18:42 ` [PATCH 1/3] NET: [DOC] Multiqueue hardware support documentation PJ Waskiewicz
2007-06-18 18:42 ` [PATCH 2/3] NET: [SCHED] Qdisc changes and sch_rr added for multiqueue PJ Waskiewicz
2007-06-18 19:05 ` Patrick McHardy
2007-06-18 20:36 ` Waskiewicz Jr, Peter P
2007-06-18 20:54 ` Patrick McHardy
2007-06-18 21:04 ` Waskiewicz Jr, Peter P
2007-06-18 21:11 ` Patrick McHardy
2007-06-21 17:55 ` Waskiewicz Jr, Peter P
2007-06-21 18:04 ` Patrick McHardy
2007-06-21 18:12 ` Waskiewicz Jr, Peter P
2007-06-21 18:17 ` Patrick McHardy
2007-06-21 18:23 ` Waskiewicz Jr, Peter P
2007-06-21 19:10 ` Patrick McHardy
2007-06-21 20:15 ` Waskiewicz Jr, Peter P
2007-06-18 18:42 ` [PATCH 3/3] NET: [CORE] Stack changes to add multiqueue hardware support API PJ Waskiewicz
2007-06-18 19:10 ` Patrick McHardy
2007-06-18 20:26 ` Waskiewicz Jr, Peter P
2007-06-18 20:28 ` Patrick McHardy [this message]
2007-06-19 6:28 ` David Miller
2007-06-19 17:31 ` Waskiewicz Jr, Peter P
2007-06-19 20:01 ` Waskiewicz Jr, Peter P
2007-06-19 22:37 ` David Miller
2007-06-19 23:11 ` Waskiewicz Jr, Peter P
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4676EAFE.8040601@trash.net \
--to=kaber@trash.net \
--cc=auke-jan.h.kok@intel.com \
--cc=davem@davemloft.net \
--cc=hadi@cyberus.ca \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.