All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alex Tomas <alex@clusterfs.com>
To: Girish Shilamkar <girish@clusterfs.com>
Cc: Ext4 Mailing List <linux-ext4@vger.kernel.org>,
	Theodore Tso <tytso@mit.edu>,
	Andreas Dilger <adilger@clusterfs.com>
Subject: Re: Updated patches for journal checksums.
Date: Tue, 19 Jun 2007 12:03:10 +0400	[thread overview]
Message-ID: <46778DBE.3090801@clusterfs.com> (raw)
In-Reply-To: <1182239437.3784.11.camel@dhcp7.linsyssoft.com>

say, at mount time we fund transaction logged. this means part of it can be
on a disk. what do we do if transaction in the journal is found with wrong
checksum? leave partial transaction in-place?

thanks, Alex

Girish Shilamkar wrote:
> Hi,
> 	The journal checksums patches for ext4 and e2fsprogs sent on 30th May
> had run into problems on big-endian machines. I have made the required
> changes. 
> The major updates are:
> 1. Checksum was written in little endian format in the commit header,
> changed it to big-endian.
> 2. The crc32 code ported to userspace (which is used by e2fsprogs) had
> problem with #ifdef, fixed that.
> 3. The crc32 user space code used i386 assembly code for swabbing
> changed it to generic one.
> 4. Removed various #includes, which caused compilation errors on ppc
> machine.
> 
> Any comments/suggestions are always welcome.
> 
> Thanks,
> Girish.
> 

  reply	other threads:[~2007-06-19  8:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-19  7:50 Updated patches for journal checksums Girish Shilamkar
2007-06-19  8:03 ` Alex Tomas [this message]
2007-06-19  8:15   ` Girish Shilamkar
2007-06-19  8:51     ` Andreas Dilger
2007-06-19  9:10       ` Alex Tomas
2007-06-19 19:06         ` Andreas Dilger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46778DBE.3090801@clusterfs.com \
    --to=alex@clusterfs.com \
    --cc=adilger@clusterfs.com \
    --cc=girish@clusterfs.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.