From: "Jan Beulich" <jbeulich@novell.com>
To: Keir Fraser <Keir.Fraser@cl.cam.ac.uk>, xen-devel@lists.xensource.com
Subject: Re: [PATCH] x86: clear guest's EFLAGS.RF after emulating instructions
Date: Tue, 19 Jun 2007 11:09:55 +0100 [thread overview]
Message-ID: <4677C793.76E4.0078.0@novell.com> (raw)
In-Reply-To: <C29D67AB.10DEB%Keir.Fraser@cl.cam.ac.uk>
>You set EFLAGS.RF in a few places when injecting #PF. Why would you do that?
>It isn't Xen's job to set that flag ever afaics, and since the original trap
>into Xen was not due to #DB you're not avoiding an infinite loop.
This is only in handle_mmio() where I cleared the flag earlier - since #PF has lower
priority than #DB, .RF must have been set when the exception was reported, and
hence I must re-set it when forwarding the exception.
Jan
next prev parent reply other threads:[~2007-06-19 10:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-19 9:53 [PATCH] x86: clear guest's EFLAGS.RF after emulating instructions Jan Beulich
2007-06-19 9:59 ` Keir Fraser
2007-06-19 10:09 ` Jan Beulich [this message]
2007-06-19 10:19 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4677C793.76E4.0078.0@novell.com \
--to=jbeulich@novell.com \
--cc=Keir.Fraser@cl.cam.ac.uk \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.