From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [PATCH] x86: eliminate x86_emulate's private EFLAGS definitions Date: Tue, 19 Jun 2007 11:21:47 +0100 Message-ID: <4677CA5B.76E4.0078.0@novell.com> References: <4677C411.76E4.0078.0@novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org >>> Keir Fraser 19.06.07 12:05 >>> >On 19/6/07 10:54, "Jan Beulich" wrote: > >> .. in favor of using one of the two (i.e. already redundant) ones >> found in the headers. >>=20 >> Signed-off-by: Jan Beulich > >Currently x86_emulate is buildable 'out of tree', e.g., in tools/tests. I >want to keep that ability but it is the case that down the line we'll be >wanting more flags and structures to be sharable outside x86_emulate.c. = I'm >not sure yet what the right way of achieving that will be. Yes, I was afraid of something like that (I just didn't know that I might = be able to build the thing in tools/tests, I thought this was completely out of = tree, and hence adding a local header would be possible). In that light, perhaps doing a little cleanup on the headers having the = desired definitions, so that they can be included for the tool build, will do. I = may find some time to look into this possibility. Jan