From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Tue, 19 Jun 2007 18:25:33 +0100 (BST) Received: from h155.mvista.com ([63.81.120.155]:50071 "EHLO imap.sh.mvista.com") by ftp.linux-mips.org with ESMTP id S20023694AbXFSRZa (ORCPT ); Tue, 19 Jun 2007 18:25:30 +0100 Received: from [192.168.1.248] (unknown [10.150.0.9]) by imap.sh.mvista.com (Postfix) with ESMTP id 7F0183EC9; Tue, 19 Jun 2007 10:24:57 -0700 (PDT) Message-ID: <467811D0.3070409@ru.mvista.com> Date: Tue, 19 Jun 2007 21:26:40 +0400 From: Sergei Shtylyov Organization: MontaVista Software Inc. User-Agent: Mozilla/5.0 (X11; U; Linux i686; rv:1.7.2) Gecko/20040803 X-Accept-Language: ru, en-us, en-gb MIME-Version: 1.0 To: Franck Bui-Huu Cc: Atsushi Nemoto , ralf@linux-mips.org, macro@linux-mips.org, linux-mips@linux-mips.org Subject: Re: [PATCH 3/5] Deforest the function pointer jungle in the time code. References: <20070619.005121.118948229.anemo@mba.ocn.ne.jp> <20070620.010805.23009775.anemo@mba.ocn.ne.jp> In-Reply-To: Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 15470 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: sshtylyov@ru.mvista.com Precedence: bulk X-list: linux-mips Franck Bui-Huu wrote: >> On Tue, 19 Jun 2007 09:33:33 +0200, "Franck Bui-Huu" >> wrote: >> > What do you mean by "pnx8550 can have customized copy of cp0_hpt >> > routines" ? Do you mean that it should copy the whole clock event >> > driver ? >> > It seems to me that using cp0 hpt as a clock event only is a valid >> usage... >> Well, I thought the customized cp0 clockevent codes (custom >> .set_next_event routine is needed anyway, isn't it?) > I don't think so. > hpt-cp0.c clock event part doesn't care if the counter is cleared when > an interrupt is triggered. Well, in the generic case it must read back the Count reg. before writing to the Compare reg. and for PNX8550 this is unnecessary -- but indeed, should not harm... > It matters only for clock source (well I > think) that's why I suggested to rewrite a clock source driver only > for this platform... Yeah, this platform certainly *needs* another clocksource than the counter used for the clock events -- currently it's count/compare 2. And this platform also *needs* a separate clocksource driver as well since the PNX8550 counters *do* support auto-reaload mode here -- in fact, this seems to be the only supported mode from the manual excerpt cited here: http://www.linux-mips.org/archives/linux-mips/2006-12/msg00194.html WBR, Sergei