Re: [PATCH] relay-file-read-start-pos-fix.patch

[Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>]

Tom Zanussi wrote:
> Hi,
> 
> I haven't had a chance to test it myself yet, but it looks ok to me,
> except for one problem noted below...

Hi,

Thank you so much!
I'm preparing how it can reproduce. I'll send it as soon as possible.

> Thanks for fixing it.
> 
>> Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
>>
>> ---
>>  kernel/relay.c |    8 ++++++--
>>  1 file changed, 6 insertions(+), 2 deletions(-)
>>
>> Index: linux-2.6.22-rc4-mm2/kernel/relay.c
>> ===================================================================
>> --- linux-2.6.22-rc4-mm2.orig/kernel/relay.c	2007-06-13 20:22:02.000000000 +0900
>> +++ linux-2.6.22-rc4-mm2/kernel/relay.c	2007-06-18 23:00:54.000000000 +0900
>> @@ -812,7 +812,10 @@
>>  	}
>>
>>  	buf->bytes_consumed += bytes_consumed;
>> -	read_subbuf = read_pos / buf->chan->subbuf_size;
>> +	if (!read_pos)
>> +		read_subbuf = buf->subbufs_consumed;
> 
> I think this should be instead:
> 
> +		read_subbuf = buf->subbufs_consumed % n_subbufs;

Yes, you are right.
Thank you again.

-- 
Masami HIRAMATSU
Linux Technology Center
Hitachi, Ltd., Systems Development Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com