From: Sergey Yanovich <ynvich@gmail.com>
To: Eric Wong <normalperson@yhbt.net>
Cc: git@vger.kernel.org, J.Sixt@eudaptics.com, masterdriverz@gmail.com
Subject: Re: [PATCH 1/3] Accept root <tree-ish> in 'git-svn commit-diff'
Date: Wed, 20 Jun 2007 12:20:59 +0300 [thread overview]
Message-ID: <4678F17B.8010902@gmail.com> (raw)
In-Reply-To: <20070620062548.GA25840@muzzle>
Eric Wong wrote:
>> - push @diff_tree, $tree_a, $tree_b;
>> + if ($tree_a eq '0000000000000000000000000000000000000000') {
>
> You can make this more legible by using '0' x40 instead of repeating
> 40 '0' characters. Also, it might be a good idea to support --root
> directly for git-svn so the user won't have to type 40 zeroes in the
> command-line :)
>
Sorry, I am not a perl expert or even user.
I did try to process '--root' in 'git-svn', but in vain. And I can
explain, why 40 '0'. That is the only reference to root commit as an
object that I managed to find in git - in the output of 'git-rev-list'.
If 40 '0' is not good, then it may worth to introduce a shorthand for
it, just as we have one for 'HEAD'. 'NULL' or 'ROOT' may be. If this is
implemented in 'git-rev-list', there will be no need to change 'git-svn'
at all.
next prev parent reply other threads:[~2007-06-20 9:20 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-18 12:14 git tool to keep a subversion mirror Sergey Yanovich
2007-06-19 6:54 ` [PATCH 1/3] Accept root <tree-ish> in 'git-svn commit-diff' Sergey Yanovich
2007-06-19 6:54 ` Sergey Yanovich
2007-06-19 6:54 ` [PATCH 2/3] 'git-svndump' Sergey Yanovich
2007-06-19 6:54 ` Sergey Yanovich
2007-06-20 6:40 ` Eric Wong
2007-06-20 9:47 ` Sergey Yanovich
2007-06-19 6:54 ` [PATCH 3/3] Fix large-scale exports by 'git-svndump' Sergey Yanovich
2007-06-19 6:54 ` Sergey Yanovich
2007-06-20 6:25 ` [PATCH 1/3] Accept root <tree-ish> in 'git-svn commit-diff' Eric Wong
2007-06-20 9:20 ` Sergey Yanovich [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-06-17 18:49 git tool to keep a subversion mirror Sergey Yanovich
2007-06-17 21:09 ` Matthieu Moy
2007-06-18 6:42 ` Sergey Yanovich
2007-06-18 12:14 ` [PATCH 1/3] Accept root <tree-ish> in 'git-svn commit-diff' Sergey Yanovich
2007-06-18 12:14 ` Sergey Yanovich
2007-06-18 13:20 ` Johannes Sixt
2007-06-18 12:14 ` [PATCH 2/3] 'git-svndump' Sergey Yanovich
2007-06-18 12:14 ` Sergey Yanovich
2007-06-18 12:26 ` Charlie Shepherd
2007-06-18 12:14 ` [PATCH 3/3] Fix large-scale exports by 'git-svndump' Sergey Yanovich
2007-06-18 12:14 ` Sergey Yanovich
2007-06-18 13:22 ` Johannes Sixt
2007-06-24 7:45 ` git tool to keep a subversion mirror Jan Hudec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4678F17B.8010902@gmail.com \
--to=ynvich@gmail.com \
--cc=J.Sixt@eudaptics.com \
--cc=git@vger.kernel.org \
--cc=masterdriverz@gmail.com \
--cc=normalperson@yhbt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.