From: "Jan Beulich" <jbeulich@novell.com>
To: xen-devel@lists.xensource.com, Keir Fraser <keir@xensource.com>
Subject: Re: [PATCH] x86: machine check exception handling
Date: Fri, 22 Jun 2007 07:57:22 +0100 [thread overview]
Message-ID: <467B8EF2.76E4.0078.0@novell.com> (raw)
In-Reply-To: <C2A04698.11088%keir@xensource.com>
> 3. Most contentious, I'm sure: removed VMX changes that would keep
>interrupts disabled across NMI/MCE. The reason is simply that SVM does not
>bother with this. If there is a requirement that NMI/MCE be called with
>particular constraints on EFLAGS, then we should make that clear and fix up
>both VMX and SVM in a separate patch. The pain of this is that it would
>probably require extra checks on critical vmexit paths. Is it *really* that
>bad for #MC to get interrupted?
Yes, I think it is bad - the machine is known to be a in bad condition already,
and by allowing external interrupts you make the situation even worse.
Consequently I think SVM should be fixed to only conditionally enable
interrupts, just like VMX does.
Jan
next prev parent reply other threads:[~2007-06-22 6:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-19 10:06 [PATCH] x86: machine check exception handling Jan Beulich
2007-06-21 14:15 ` Keir Fraser
2007-06-21 14:38 ` Christoph Egger
2007-06-21 14:59 ` Keir Fraser
2007-06-25 11:07 ` Christoph Egger
2007-06-22 6:57 ` Jan Beulich [this message]
2007-06-22 7:15 ` Keir Fraser
2007-06-22 7:47 ` Jan Beulich
2007-06-22 7:52 ` Keir Fraser
2007-06-22 7:59 ` Keir Fraser
2007-06-22 7:01 ` Jan Beulich
2007-06-22 7:16 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=467B8EF2.76E4.0078.0@novell.com \
--to=jbeulich@novell.com \
--cc=keir@xensource.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.