From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gerd Hoffmann <kraxel@redhat.com>
Subject: [patch] crashkernel allocation failure #1
Date: Fri, 22 Jun 2007 11:39:02 +0200
Message-ID: <467B98B6.7060601@redhat.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="------------000809020005050707030109"
Return-path: <xen-devel-bounces@lists.xensource.com>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Xen Development Mailing List <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

This is a multi-part message in MIME format.
--------------000809020005050707030109
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

   Hi,

The kexec crash kernel area allocation code does some effort to move the 
images (i.e. kernel+initrd) out of the way, so the crashkernel area can 
be allocated at the default location (@16m).

In case initial_images_end is not page aligned a single page in the 
middle of the crash kernel area is leaked though, making the whole move 
effort fail.

The attached patch fixed that by rounding up initial_images_end to the 
next page boundary.

please apply,
   Gerd

--------------000809020005050707030109
Content-Type: text/x-patch;
 name="xen-crashkernel.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="xen-crashkernel.patch"

--- xen/arch/x86/setup.c.fix	2007-05-03 09:40:19.000000000 +0200
+++ xen/arch/x86/setup.c	2007-06-19 11:19:11.000000000 +0200
@@ -453,6 +453,7 @@
     if ( initial_images_start < xenheap_phys_end )
         initial_images_start = xenheap_phys_end;
     initial_images_end = initial_images_start + modules_length;
+    initial_images_end = (initial_images_end + PAGE_SIZE - 1) & PAGE_MASK;
 
     move_memory(initial_images_start, 
                 mod[0].mod_start, mod[mbi->mods_count-1].mod_end);

--------------000809020005050707030109
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

--------------000809020005050707030109--