Re: [Xenomai-core] [RFC][PATCH] shirq locking rework

[Jan Kiszka <jan.kiszka@domain.hid>]

[-- Attachment #1: Type: text/plain, Size: 1612 bytes --]

Dmitry Adamushko wrote:
> On 22/06/07, Jan Kiszka <jan.kiszka@domain.hid> wrote:
>> [ ... ]
>>
>> Only compile-tested under various .configs. Any comment welcome.
>>
> 
>> @@ -76,7 +102,7 @@ static inline void xnintr_stat_counter_d
>>  static void xnintr_irq_handler(unsigned irq, void *cookie)
>>  {
>>         xnsched_t *sched = xnpod_current_sched();
>> -       xnintr_t *intr = (xnintr_t *)cookie;
>> +       xnintr_t *intr;
>>         xnstat_runtime_t *prev;
>>         xnticks_t start;
>>         int s;
>> @@ -86,6 +112,16 @@ static void xnintr_irq_handler(unsigned
>>         xnltt_log_event(xeno_ev_ienter, irq);
>>
>>         ++sched->inesting;
>> +
>> +       xnlock_get(&xnirqs[irq].lock);
>> +
>> +#ifdef CONFIG_SMP
>> +       /* In SMP case, we have to reload the cookie under the per-IRQ
>> lock
>> +          to avoid racing with xnintr_detach. */
>> +       intr = rthal_irq_cookie(&rthal_domain, irq);
>> +#else
>> +       intr = cookie;
>> +#endif
>>         s = intr->isr(intr);
> 
> I guess, 'intr' can be NULL here.

Yeah, needs to be caught as well.

> 
> Could you please send me attached (non-inlined) a combo patch on top
> of the trunk version (as I see this one seems to be on top of your
> previous one)? I'll try to come up with some solution during this
> weekend.

My patch was an attachment (though I wonder we everyone has so much
problems with inlines - broken mailers all over the place), and it was
already against trunk (#2654). Philippe merged my preliminary fix this
morning.

Looking forward to your suggestions!

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 250 bytes --]