From: Wolfgang Grandegger <wg@grandegger.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] command loads broken since a while
Date: Fri, 22 Jun 2007 15:05:56 +0200 [thread overview]
Message-ID: <467BC934.4090601@grandegger.com> (raw)
Hello,
recently, I realized that the U-Boot command "loads" is broken and the
attached preliminary patch fixes it:
diff --git a/common/cmd_load.c b/common/cmd_load.c
index f63b8e8..2d9e0f0 100644
--- a/common/cmd_load.c
+++ b/common/cmd_load.c
@@ -240,12 +240,14 @@ read_record (char *buf, ulong len)
*p = c;
}
+#if 0
/* Check for the console hangup (if any different from serial) */
if (gd->jt[XF_getc] != getc) {
if (ctrlc()) {
return (-1);
}
}
+#endif
}
/* line too long - truncate */
The error sneaked in, when serial_getc was replaced with getc some time
in the past. Can somebody tell me what the above code snippet is good
for? I cannot see how to run the transfer over a line not being the
console but maybe I have missed something.
Wolfgang.
reply other threads:[~2007-06-22 13:05 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=467BC934.4090601@grandegger.com \
--to=wg@grandegger.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.