From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephan Berberig Subject: Re: [PATCH] ACPI: bay: send envp with uevent - fix Date: Sat, 23 Jun 2007 01:12:58 +0200 Message-ID: <467C577A.5010904@arcor.de> References: <466A719F.3010509@arcor.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Return-path: Received: from main.gmane.org ([80.91.229.2]:44576 "EHLO ciao.gmane.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751385AbXFVXRh (ORCPT ); Fri, 22 Jun 2007 19:17:37 -0400 Received: from list by ciao.gmane.org with local (Exim 4.43) id 1I1sMR-0003sr-88 for linux-acpi@vger.kernel.org; Sat, 23 Jun 2007 01:16:15 +0200 Received: from pd9e02337.dip0.t-ipconnect.de ([217.224.35.55]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 23 Jun 2007 01:16:15 +0200 Received: from s.berberig by pd9e02337.dip0.t-ipconnect.de with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 23 Jun 2007 01:16:15 +0200 In-Reply-To: <466A719F.3010509@arcor.de> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: linux-acpi@vger.kernel.org Hi Len, any news about applying this patch to acpi-test? I got Kristen's Acked-by by private email. Best regards, Stephan Stephan Berberig schrieb: > Hi, > attached a patch to fix the bay uevent so that udev doesn't get confused. > > Kristen, could I get your Acked-by? > > Best regards, > Stephan > > > ------------------------------------------------------------------------ > > There must not be a new-line character in the uevent. Otherwise, udev gets confused. > Thanks to Kay Sievers for pointing it out. > > Signed-off-by: Stephan Berberig > CC: Kristen Carlson Accardi > > --- a/drivers/acpi/bay.c 2007-06-08 12:01:11.000000000 +0200 > +++ b/drivers/acpi/bay.c 2007-06-08 12:02:49.000000000 +0200 > @@ -337,7 +337,7 @@ > char *envp[] = { event_string, NULL }; > > bay_dprintk(handle, "Bay event"); > - sprintf(event_string, "BAY_EVENT=%d\n", event); > + sprintf(event_string, "BAY_EVENT=%d", event); > kobject_uevent_env(&dev->kobj, KOBJ_CHANGE, envp); > } >