From: Patrick McHardy <kaber@trash.net>
To: Yasuyuki KOZAKAI <yasuyuki.kozakai@toshiba.co.jp>
Cc: rusty@rustcorp.com.au, netfilter-devel@lists.netfilter.org,
pablo@netfilter.org, kadlec@blackhole.kfki.hu
Subject: Re: [RFC][PATCH 0/10]: ct_extend
Date: Mon, 25 Jun 2007 12:16:35 +0200 [thread overview]
Message-ID: <467F9603.2070005@trash.net> (raw)
In-Reply-To: <200706250314.l5P3E2M4008231@toshiba.co.jp>
Yasuyuki KOZAKAI wrote:
> Hi,
>
> This patch set is a snapshot of the ct_extend, which shrinks memory
> usage where extensions such as NAT and helper are not used.
>
> I've applied all suggestions from Patrick. If nat module is loaded,
> ct_extend pre-allocates extended area of NAT when it initially allocates
> extended area of helper. I've also renamed functions to nf_ct_ext_* and
> merged the members in 'struct nf_nat_info' into 'struct nf_conn_nat'.
The patches look pretty good to me. For normal conntracks without
NAT or helpers its a clear win since we avoid the double search of
expectations. The only case I'm a bit worried about is NAT, for that
case we get an extra allocation for every new connection. But I
guess thats better than what we have now, the double search reportedly
costs about 10% performance for all cases.
Do you think we should put these patches in 2.6.23?
next prev parent reply other threads:[~2007-06-25 10:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-25 3:14 [RFC][PATCH 0/10]: ct_extend Yasuyuki KOZAKAI
2007-06-25 10:16 ` Patrick McHardy [this message]
2007-06-25 16:49 ` Yasuyuki KOZAKAI
[not found] ` <200706251649.l5PGn3eL021623@toshiba.co.jp>
2007-06-25 18:05 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=467F9603.2070005@trash.net \
--to=kaber@trash.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=netfilter-devel@lists.netfilter.org \
--cc=pablo@netfilter.org \
--cc=rusty@rustcorp.com.au \
--cc=yasuyuki.kozakai@toshiba.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.