From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: xt_connlimit 20070625 Date: Mon, 25 Jun 2007 13:45:10 +0200 Message-ID: <467FAAC6.3070904@trash.net> References: <467BAF07.6020502@trash.net> <467FA9CE.8000805@trash.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Netfilter Developer Mailing List To: Jan Engelhardt Return-path: In-Reply-To: <467FA9CE.8000805@trash.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: netfilter-devel-bounces@lists.netfilter.org Errors-To: netfilter-devel-bounces@lists.netfilter.org List-Id: netfilter-devel.vger.kernel.org Patrick McHardy wrote: > Jan Engelhardt wrote: >> + found_ct = NULL; >> + >> + if (found != NULL) >> + found_ct = nf_ct_tuplehash_to_ctrack(found); >> + >> + if (found_ct != NULL && >> > Can't be NULL here. > OK it can. But you should probably just continue for found == NULL above.